New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GIST-26): fix some auth quirks about providers and cookies #10

Merged

Courtcircuits merged 2 commits into main from feature/gist-26-authentication-quirks-fixes

Aug 21, 2024

Member

Courtcircuits commented Aug 21, 2024

No description provided.


          wip(GIST-26): fixed cookie rewrite middleware

7dc1370

linear bot commented Aug 21, 2024

GIST-26 Authentication quirks fixes

When adding api calls to frontend, I came across a few quirks about the authentication process :

the cookie middleware doesn't get the gists.access_token but the auth
usernames are not set correctly depending on the provider
- Github should use -> RawData.Login
- Google should use the first part of the email (before the )
In the database the type is not set for local auth


          wip(GIST-26): fixed user creation strategy

d94d534

Courtcircuits merged commit 70b64bc into main

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet