Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft : feat(GIST-78): added ABAC on gists #25

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

Courtcircuits
Copy link
Member

@Courtcircuits Courtcircuits commented Nov 4, 2024

This PR implements ABAC for gists

WARNING : It hasn't been tested yet and this PR can potentially to a leak of confidential user data. Please review it carefully before merging + wait for the addition of tests.

  • also need rollback migration script IF it goes wrong in production

Copy link

linear bot commented Nov 4, 2024

GIST-78 Manage access rights on gists

We need to add access rights on some gists :

  • read
    • if gist is public, anyone
    • if gist is private, you need to specify whether a user can read/write a gist
  • update (which is writing, basically)
    • if gist is public, need to give the right to write
    • if gist is private, same as read

image.png

image.png

@Courtcircuits Courtcircuits changed the title feat(GIST-78): added ABAC on gists Draft : feat(GIST-78): added ABAC on gists Nov 4, 2024
ops: added coverage to ci

ops: fix ci i hope

ops: fix ci i hope 2

ops: fix ci i hope 3

ops: fix ci i hope 4

ops: fix ci i hope 5

ops: fix ci i hope

ops: setup ci yeah
@Courtcircuits Courtcircuits force-pushed the feature/gist-78-manage-access-rights-on-gists branch from b9aed4a to 269580a Compare November 6, 2024 12:43
@Courtcircuits Courtcircuits merged commit a60730e into main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant