mingit: exclude the tzdata #633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 53038d4 (ci: avoid building the installer multiple times, 2023-08-28), I added code to limit where the `installer` artifact is built, but forgot to do that _before_ the `releaseable.txt` file is shown. Signed-off-by: Johannes Schindelin <[email protected]>
In 53038d4 (ci: avoid building the installer multiple times, 2023-08-28), I claimed that the MinGit artifact is already built in the `sdk-artifacts` matrix. That is only _kind_ of true: As part of building the `build-installers` SDK artifact, there _is_ a part where the a minimal SDK is built, but not MinGit. Let's build MinGit again when code was touched that changes how it is built. Signed-off-by: Johannes Schindelin <[email protected]>
Since msys2/MINGW-packages#24750, the `mingw-w64-gcc-libs` package now has a hard dependency on `mingw-w64-tzdata`. That latter package contains, let's say, _many_ files. As a consequence, the `7z` invocation to build MinGit would now fail like this: Creating .zip archive + cd / + 7z a -mx9 [...] release.sh: line 176: /mingw64/bin/7z: Argument list too long Error: Process completed with exit code 126. Since the new code that makes use of that tzdata explicitly comes with a fall-back to an internal database, let's just skip the tzdata when building MinGit. Signed-off-by: Johannes Schindelin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since msys2/MINGW-packages#24750, the
mingw-w64-gcc-libspackage now has a hard dependency onmingw-w64-tzdata. That latter package contains, let's say, many files.As a consequence, the
7zinvocation to build MinGit would now fail like this:This is the underlying reason for the recent
git-artifactsCI failures:Since the new code that makes use of that tzdata explicitly comes with a fall-back to an internal database, let's just skip the tzdata when building MinGit.