Rename "Downloads" to "Install" and redesign #2096
Open
+210
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a new style where we display the install instructions as tabs, with a shortcode and CSS - Update aliases - Move existing Windows/Linux/Mac pages to the new style, keeping the content the same Signed-off-by: Julia Evans <[email protected]>
Signed-off-by: Julia Evans <[email protected]>
Signed-off-by: Julia Evans <[email protected]>
Add a script that will update the homepage / sidebar links to the appropriate OS-specific link. This falls back gracefully: if the script doesn't run, you can just go to /install/ and click on the appropriate page. Signed-off-by: Julia Evans <[email protected]>
We already have a "Build from source" page
dscho
reviewed
Oct 1, 2025
layouts/partials/sidebar.html
Outdated
| <a href="{{ relURL "downloads/logos" }}"{{ if (eq .Params.Subsection "logos") }} class="active"{{ end }}>Logos</a> | ||
| </li> | ||
| </ul> | ||
| <a href="{{ relURL "install" }}"{{ if (eq $section "install") }} class="active"{{ end }}>Install</a> |
There was a problem hiding this comment.
I think this is the reason why the Playwright tests fail now...
Error: expect.not.toHaveClass: Error: strict mode violation: getByRole('link', { name: 'All' }) resolved to 2 elements:
1) <a class="install-link" href="http://localhost:5000/install/win">Install</a> aka getByRole('link', { name: 'Install' })
2) <a href="#" data-os="" class="subtle-button gui-os-filter">All</a> aka getByRole('link', { name: 'All', exact: true })
Call log:
- Expect "not toHaveClass" with timeout 5000ms
- waiting for getByRole('link', { name: 'All' })
66 |
67 | const allButton = page.getByRole('link', { name: 'All' })
> 68 | await expect(allButton).not.toHaveClass(/selected/)
| ^
69 |
70 | const thumbnails = page.locator('.gui-thumbnails li:visible')
71 | const count = await thumbnails.count()
at /home/runner/work/git-scm.com/git-scm.com/tests/git-scm.spec.js:68:33
We probably need to change this line:
const allButton = page.getByRole('link', { name: 'All' }) const allButton = page.getByRole('link', { name: 'All', exact: true })There was a problem hiding this comment.
thank you for looking into that, will try that fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames "Downloads" to "Install" and redesigns the page to simplify it a lot. You can see it in action here: https://jvns.github.io/git-scm.com/install/win
I'm still not sure where the Logos page should be linked. Maybe in About?
I've designed it as "tabs", where each tab is a separate page. I did it that way for accessibility (though I'm very far from an accessibility expert): the idea is that it would be easier for someone using a screenreader if they don't have to navigate through a bunch of irrelevant content. The
install-headershortcode is rendered in an awkward way (you have to close someThe Install links on the sidebar and homepage get automatically updated with Javascript to point to the appropriate page.
The Build from Source page is pretty sparse right now, maybe it would be good in the future to point users to instructions for how to build Git from source.
Todos: