feat: branch diff adjust icons for file status #12117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Modify the icons for the file status list when comparing branches with a common base, the info with feedback for where the files are changed: Unequal/B (second), A (first), Same (both changes the same).
Color is added to give some feedback of the change in addition to the (pixel) character: B (blue-violet), A (yellow) and same (green) (unequal was red already).
Some minor anti-aliasing too.
Also prepare the icons for dark mode.
Edit: also updated added/removed/copied/renamed (just modified first) (all submodule related are not changed, as before).
Related to #12111
This could be handled in that PR too, but the intention is that that PR in itself should have a minimal of changes to the light mode.
PHYs attribute has been removed with TweakPng
Screenshots
Before
Dark mode is not used, but the pixel char is hard to see with dark text


After
Slightly darker background than in the app



Test methodology
Visual
Test environment(s)
Win11
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.