Pr/daniel noland/tap phase 3 #752
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior method was somewhat error-prone and won't scale to more network interface types. This method uses the `kind` field from netlink to eliminate various types of error cases. Signed-off-by: Daniel Noland <[email protected]>
The prior scheme assumed all physical network devices were PCI devices, which isn't strictly true. There is no rule against having an eswitch / devlink device which is not directly related to pci. Indeed, the netdev sim device is exactly that. Signed-off-by: Daniel Noland <[email protected]>
The switch id provided by netdevsim devices is longer than the 32 bytes assumed in the netlink message structure. This commit accounts for that. Signed-off-by: Daniel Noland <[email protected]>
rustc caught a pinning error in the design of the tap device creation. If the low level object is moved during async execution it will result in undefined behavior. The fix is to Box<Pin<_>> the data before handing it to linux to forbid that outcome. Signed-off-by: Daniel Noland <[email protected]>
The spacing produced by the prior approach is wrong (no space between fields) Signed-off-by: Daniel Noland <[email protected]>
This commit adds support for creating tap devices from the interface manager. Note that the mechanics of creating and removing tap devices are different. They are created via ioctl but deleted via netlink. Signed-off-by: Daniel Noland <[email protected]>
The extant pci types are too broadly scoped. They functionally allow you to default all the fields, making the type somewhat meaningless. At the minimum, PCI devices should always have a bus:device.function set. This commit reworks those mechanics. Signed-off-by: Daniel Noland <[email protected]>
The bus type will allow us to distinguish between pci devices and netdevsim devices in a future commit. Signed-off-by: Daniel Noland <[email protected]>
This commit introduces the early mechanics needed to create simulated network devices. These simulated devices will be useful in a series of follow on PRs for testing DPDK et al. This commit is a breaking change because it expands the available bus types. Signed-off-by: Daniel Noland <[email protected]>
This commit introduces support for "dummy" (i.e. additional loopback) network interfaces. Dummy devices will be used later as low complexity proxies for physical interfaces. Signed-off-by: Daniel Noland <[email protected]>
Signed-off-by: Daniel Noland <[email protected]>
Signed-off-by: Daniel Noland <[email protected]>
This is / was a mess. Slightly less so now. Signed-off-by: Daniel Noland <[email protected]>
Signed-off-by: Daniel Noland <[email protected]>
Signed-off-by: Daniel Noland <[email protected]>
Signed-off-by: Daniel Noland <[email protected]>
Signed-off-by: Daniel Noland <[email protected]>
Signed-off-by: Daniel Noland <[email protected]>
Signed-off-by: Daniel Noland <[email protected]>
Signed-off-by: Daniel Noland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still scratch, don't review yet