Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withdraw [GHSA-29qp-crvh-w22m] github.com/hashicorp/yamux's DefaultConfig has dangerous defaults causing hung Read #5250

Merged
merged 1 commit into from
Feb 6, 2025
Merged

withdraw [GHSA-29qp-crvh-w22m] github.com/hashicorp/yamux's DefaultConfig has dangerous defaults causing hung Read #5250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions advisories/github-reviewed/2025/01/GHSA-29qp-crvh-w22m/GHSA-29qp-crvh-w22m.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
{
"schema_version": "1.4.0",
"id": "GHSA-29qp-crvh-w22m",
"modified": "2025-01-29T19:19:11Z",
"modified": "2025-01-29T19:19:13Z",
"published": "2025-01-29T19:19:11Z",
"aliases": [],
"aliases": [

],
"summary": "github.com/hashicorp/yamux's DefaultConfig has dangerous defaults causing hung Read",
"details": "The default values for Session.config.KeepAliveInterval and Session.config.ConnectionWriteTimeout of 30s and 10s create the possibility for timed out writes that most aren't handling in their readers.\n\nCalls to Stream.Read on one side of a connection will hang until the underlying Session is closed if the corresponding Stream.Write call on the other side it's waiting for returns with ErrConnectionWriteTimeout. This happens in the case of network congestion between the two sides.\n\nIf you keep Session.sendCh full (fixed capacity of 64) for ConnectionWriteTimeout, but for less than the KeepAliveInterval + ConnectionWriteTimeout (which would kill the Session), Stream.Write will return ErrConnectionWriteTimeout. The state of the underlying Session or Stream is not modified. When this happens, the other side's Stream.Read call that's waiting for that write will never return because there's no timeout for this edge-case.\n\nSince no keep alive timed out, you can continue to use the Session once the network congestion is resolved, but that Stream.Read call will only return when the Session closes or the response shows up. Since the write call on the other side timed out the call to Stream.Read will never return.\n\nAny conditions that cause network writes to stall for 10-30 seconds can trigger this Denial of Service- extremely high CPU contention on either side of the connection, BGP reconvergence, etc. To resolve the Denial of Service issue, you have to re-establish the connections, which will usually require a hard restart of the service on either end of the connection.",
"severity": [
{
"type": "CVSS_V4",
"score": "CVSS:4.0/AV:N/AC:L/AT:N/PR:N/UI:N/VC:N/VI:N/VA:H/SC:N/SI:N/SA:N/E:U"
}

],
"affected": [
{
Expand Down Expand Up @@ -55,7 +54,7 @@
"cwe_ids": [
"CWE-770"
],
"severity": "MODERATE",
"severity": "LOW",
"github_reviewed": true,
"github_reviewed_at": "2025-01-29T19:19:11Z",
"nvd_published_at": null
Expand Down
Loading