Convert more dataflow queries to the new dataflow library #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observe that this change moves the alert location from the last assignment of an output parameter to the paramter itself, which seems a non-critical change.
The `getReassertingCall` predicate is only used by SIG34-C, whose tests still pass.
Observe that the special case for global variables is no longer needed, as these are properly handled in the new dataflow library.
MathiasVP
approved these changes
Jul 11, 2025
c/cert/src/rules/EXP37-C/DoNotCallFunctionPointerWithIncompatibleType.ql
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit-by-commit review is recommended.