Rust: Handle pub extern crate in path resolution
#20842
Merged
+15
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/path-resolution-extern-crate-visibility
branch
from
e06b4d5 to
d46ecad
Compare
Copilot finished reviewing on behalf of
hvitved
November 15, 2025 19:06
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for pub extern crate declarations in path resolution. Previously, all extern crate declarations were treated as internal-only, but now public extern crates are properly exposed to external modules.
Key changes:
- Updated
externCrateEdgepredicate to accept aSuccessorKindparameter and determine visibility based on whether the extern crate is public - Modified
ExternCrateItemNode.getVisibility()to return the actual visibility instead ofnone()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
geoffw0
reviewed
Nov 18, 2025
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
Would be nice to have a test for this.
hvitved
force-pushed
the
rust/path-resolution-extern-crate-visibility
branch
from
d46ecad to
3d49eff
Compare
Contributor
Author
I have added an integration test for this (we cannot do it with a normal QL test). |
geoffw0
approved these changes
Nov 20, 2025
Contributor
geoffw0
left a comment
geoffw0
left a comment
There was a problem hiding this comment.
I have added an integration test for this (we cannot do it with a normal QL test).
Thanks.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DCA reports a small increase in resolved calls.