Rust: Use ToIndex instead of FromIndex in ranked forex predicates
#20848
+16
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ToIndex` makes more sense, since we start the recursion from `0`.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors predicate naming in the type inference system by renaming predicates from FromIndex to ToIndex to better reflect the recursion direction, which starts from index 0 and counts upward.
- Renamed multiple recursive predicates across the type inference codebase
- Updated all references to use the new
ToIndexnaming convention
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| shared/typeinference/codeql/typeinference/internal/TypeInference.qll | Renamed four recursive predicates from FromIndex to ToIndex variants to better reflect that recursion starts from 0 |
| rust/ql/lib/codeql/rust/internal/typeinference/FunctionType.qll | Renamed module and predicate from FromIndex to ToIndex for consistency with the shared library changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pure renaming PR.
ToIndexmakes more sense, since we start the recursion from0.