Skip to content

Rust: Refactor Call class implementation #20863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Rust: Refactor Call class implementation #20863

wants to merge 7 commits into from
+2,558 −2,425

Conversation

@hvitved
Copy link
Contributor

@hvitved hvitved commented Nov 18, 2025

No description provided.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Nov 18, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 18, 2025
View reviewed changes
@hvitved hvitved force-pushed the rust/call-refactor branch 2 times, most recently from 27fdd29 to d068588 Compare November 19, 2025 13:40
@hvitved hvitved force-pushed the rust/call-refactor branch 5 times, most recently from b044b33 to f829afd Compare November 20, 2025 10:37
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2025
View reviewed changes
rust/ql/lib/codeql/rust/elements/MethodCallExpr.qll
private import internal.MethodCallExprImpl
import codeql.rust.elements.CallExprBase
import codeql.rust.elements.ArgList
import codeql.rust.elements.Attr

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.CallExprBase
Loading
.
@hvitved hvitved force-pushed the rust/call-refactor branch 3 times, most recently from 3938385 to 3346914 Compare November 21, 2025 09:50
@hvitved hvitved force-pushed the rust/call-refactor branch 2 times, most recently from ff7dd62 to 2559678 Compare November 21, 2025 11:27
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2025
View reviewed changes
rust/ql/lib/codeql/rust/elements/ParenArgsExpr.qll
private import internal.ParenArgsExprImpl
import codeql.rust.elements.ArgList
import codeql.rust.elements.Attr
import codeql.rust.elements.Expr

Check warning

Code scanning / CodeQL

Redundant import Warning

Redundant import, the module is already imported inside
codeql.rust.elements.ArgList
Loading
.
rust/ql/lib/codeql/rust/elements/internal/generated/ParenArgsExpr.qll
private import codeql.rust.elements.internal.generated.Raw
import codeql.rust.elements.ArgList
import codeql.rust.elements.Attr
import codeql.rust.elements.Expr

Check warning

Code scanning / CodeQL

Redundant import Warning generated

Redundant import, the module is already imported inside
codeql.rust.elements.ArgList
Loading
.
rust/ql/lib/codeql/rust/frameworks/rustcrypto/RustCrypto.qll
ce.getStaticTarget().(Function).getName().getText() =
exists(CallExpr call, string rawAlgorithmName |
call = this.asExpr() and
call.getStaticTarget().(Function).getName().getText() =

Check warning

Code scanning / CodeQL

Redundant cast Warning

Redundant cast to
Function
Loading
.
rust/ql/test/extractor-tests/generated/ParenArgsExpr/ParenArgsExpr.ql

query predicate instances(ParenArgsExpr x) { toBeTested(x) and not x.isUnknown() }

query predicate getArgList(ParenArgsExpr x, ArgList getArgList) {

Check warning

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.
rust/ql/test/extractor-tests/generated/ParenArgsExpr/ParenArgsExpr.ql
toBeTested(x) and not x.isUnknown() and getArgList = x.getArgList()
}

query predicate getAttr(ParenArgsExpr x, int index, Attr getAttr) {

Check warning

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.
rust/ql/test/extractor-tests/generated/ParenArgsExpr/ParenArgsExpr.ql
toBeTested(x) and not x.isUnknown() and getAttr = x.getAttr(index)
}

query predicate getBase(ParenArgsExpr x, Expr getBase) {

Check warning

Code scanning / CodeQL

Predicates starting with "get" or "as" should return a value Warning generated test

This predicate starts with 'get' but does not return a value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Rust Pull requests that update Rust code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hvitved