Use public Ajv import in schema test (remove dist/ dependency)#5678
Conversation
dist/ dependency)
There was a problem hiding this comment.
Pull request overview
Updates the JSON schema unit test to avoid importing Ajv from an internal dist/ subpath, aiming to reduce coupling to Ajv package internals while still compiling the published awf-config.schema.json.
Changes:
- Switched the test’s Ajv import from
ajv/dist/2020to the publicajventrypoint. - Updated the type annotation for the compiled validator to use
Ajv['compile']. - Instantiated Ajv with
validateSchema: falseto keep compilation working with the draft-2020-12$schemavalue.
Show a summary per file
| File | Description |
|---|---|
| src/schema.test.ts | Replaces the internal Ajv2020 import with the public Ajv import and adjusts validator typing/instantiation in the schema test. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
| const ajv = new Ajv({ validateSchema: false }); | ||
| validate = ajv.compile(schema); |
|
@copilot address review feedback |
Done in 3f35d0a. Switched the test back to |
|
✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓 |
|
✅ Smoke Claude passed |
|
🔌 Smoke Services — All services reachable! ✅ |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅ |
|
✅ Smoke Gemini completed. All facets verified. 💎 |
|
✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓 |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
✅ Contribution Check completed successfully! Contribution guidelines review complete for PR #5678: no important missing items found; no comment needed. |
|
✅ Build Test Suite completed successfully! |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (3 files)
Coverage comparison generated by |
|
🚀 Security Guard has started processing this pull request |
|
Smoke Test Results
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra Overall status: PASS cc
|
🔥 Smoke Test Results
Overall: PASS PR: Use public Ajv import in schema test (remove
|
Smoke Test: Copilot BYOK (Direct Mode)Test Results:
Mode: Running in direct BYOK mode via Status: PASS
|
Smoke Test: Claude Engine
Overall result: PASS
|
🔬 Smoke Test Results — PAT AuthPR: Use public Ajv import in schema test (remove
Overall: ❌ FAIL — pre-step template variables were not expanded (
|
Chroot Version Comparison Results
Overall: ❌ Tests did not pass — Python and Node.js versions differ between host and chroot environments.
|
|
Smoke test results:
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
🔍 Smoke Test: API Proxy OpenTelemetry Tracing
Overall: all 5 scenarios pass. The OTEL tracing integration is functional.
|
Smoke Test: GitHub Actions Services Connectivity
Overall: FAIL — Neither Redis nor PostgreSQL service containers are reachable via
|
Gemini Engine Smoke Test Results
Overall status: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
|
Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)
|
src/schema.test.tswas importing Ajv from an internaldist/path, coupling the test to package internals. This updates the test to use Ajv’s public package entrypoint while preserving draft-2020 schema compilation behavior used by the test.Import path cleanup
ajv/dist/2020ajvMinimal test wiring update
Ajv['compile'].validateSchema: falseso the existing draft-2020 schema compile check in this test remains intact.