Skip to content

Internalize unused provider session ID helper #5680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
Jun 29, 2026
Merged

Internalize unused provider session ID helper #5680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1d9215
Initial plan
Copilot Jun 29, 2026
629342e
fix: internalize provider session id helper
Copilot Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/services/api-proxy-env-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export function buildProviderTargetEnv(config: WrapperConfig): Record<string, st
return env;
}

export function resolveProviderSessionId(config: WrapperConfig): string | undefined {
function resolveProviderSessionId(config: WrapperConfig): string | undefined {
// Auto-derivation from GITHUB_RUN_ID was removed because the Copilot
// `session_id`/`x-session-id` convention causes strict OpenAI-compatible
// BYOK targets (e.g. Azure OpenAI) to reject every request with HTTP 400.
Expand Down
17 changes: 17 additions & 0 deletions src/services/api-proxy-service-split.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,23 @@ describe('API proxy split builders', () => {
expect(env.AWF_PROVIDER_SESSION_ID).toBe('session-123');
});

it('buildProviderTargetEnv trims AWF_PROVIDER_SESSION_ID from process.env', () => {
const savedSessionId = process.env.AWF_PROVIDER_SESSION_ID;
process.env.AWF_PROVIDER_SESSION_ID = ' session-from-env ';

try {
const env = buildProviderTargetEnv({
...baseConfig,
workDir: '/tmp/awf-test',
});

expect(env.AWF_PROVIDER_SESSION_ID).toBe('session-from-env');
} finally {
if (savedSessionId !== undefined) process.env.AWF_PROVIDER_SESSION_ID = savedSessionId;
else delete process.env.AWF_PROVIDER_SESSION_ID;
}
});

it('buildAgentCredentialEnv builds isolated agent credentials', () => {
const agentEnvAdditions = buildAgentCredentialEnv({
config: {
Expand Down
Loading