fix: export missing symbols required by tests#5685
Conversation
- Export secureWipeFile from ssl-key-storage.ts (test imports it) - Export buildProviderTargetEnv from api-proxy-env-config.ts (test uses it) - Add missing import of buildProviderTargetEnv in api-proxy-service-split.test.ts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (5 files)
Coverage comparison generated by |
There was a problem hiding this comment.
Pull request overview
This PR fixes failing unit tests on main by exporting two previously-internal helpers that tests import directly, restoring the intended test/module contract.
Changes:
- Export
secureWipeFilefromsrc/ssl-key-storage.tssossl-key-storage.test.tscan import it. - Export
buildProviderTargetEnvfromsrc/services/api-proxy-env-config.tsand import it inapi-proxy-service-split.test.ts.
Show a summary per file
| File | Description |
|---|---|
| src/ssl-key-storage.ts | Exports secureWipeFile to satisfy test imports. |
| src/services/api-proxy-service-split.test.ts | Adds missing import for buildProviderTargetEnv. |
| src/services/api-proxy-env-config.ts | Exports buildProviderTargetEnv so tests can call it directly. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Low
|
@copilot address review feedback |
Addressed in |
|
✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓 |
|
✅ Smoke Gemini completed. All facets verified. 💎 Validation check |
|
🔌 Smoke Services — All services reachable! ✅ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 Smoke test started: gathering repo context and preparing required checks. |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
🚀 Security Guard has started processing this pull request |
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅ |
|
✅ Build Test Suite completed successfully! |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓 |
|
✅ Smoke Claude passed |
|
✅ Contribution Check completed successfully! Contribution guidelines review complete for PR #5685. No comment needed: the PR description is clear, changes are test-related, no new functionality requires documentation, and files remain in appropriate src locations. |
Smoke Test: Claude Engine Validation
Overall result: PASS
|
Smoke Test Results — Auth mode: PAT (COPILOT_GITHUB_TOKEN)
Overall: FAIL — file test unverifiable due to unexpanded template variables. PR: "fix: export missing symbols required by tests" — author: @lpcox
|
|
PRs:
✅ GitHub MCP Testing Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) Overall: PASS
|
🔬 Smoke Test Results
PR: fix: export missing symbols required by tests Overall: ❌ FAIL
|
|
fix: export missing symbols required by tests\nRemove unused export from API proxy env config\nStop keyword leakage in export surface\nGitHub reads: ✅\nPlaywright: ✅\nFile write/read: ✅\nDiscussion comment: ✅\nBuild: ✅\nOverall: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Smoke Test: API Proxy OpenTelemetry Tracing
All 5 scenarios passed. OTEL tracing integration is functioning correctly.
|
Smoke Test: Copilot BYOK (Direct) Mode - ✅ PASS
Mode: Direct BYOK (COPILOT_PROVIDER_API_KEY) via api-proxy → api.githubcopilot.com All systems operational @lpcox
|
Smoke Test Results
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
Chroot Runtime Version Comparison
Result: Not all runtimes match — Python and Node.js versions differ between the host and the chroot environment. Go matches. This may indicate the chroot image is using an older Ubuntu base (22.04) with older bundled runtimes than the host runner.
|
|
Smoke Test Results:
Running in direct BYOK mode via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) /cc @lpcox
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS
|
Smoke Test: GitHub Actions Services Connectivity
Overall: FAIL
|
Summary
Fixes 2 failing test suites on
maincaused by missing exports/imports:src/ssl-key-storage.test.tssecureWipeFilebut it was not exported fromssl-key-storage.tsexportkeyword tosecureWipeFilefunctionsrc/services/api-proxy-service-split.test.tsbuildProviderTargetEnvbut it was neither exported from its module nor imported in the test filebuildProviderTargetEnvfromapi-proxy-env-config.tsand add the import to the test fileVerification
All 200 test suites (3321 tests) pass after these changes.