Skip to content

fix: ensure chmod runs even when chown fails in rootless permission repair #5766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 1 commit into from
Jul 1, 2026
Merged

fix: ensure chmod runs even when chown fails in rootless permission repair #5766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/artifact-permissions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
}

const existingDirs = dirs.filter(
(dir): dir is string => typeof dir === 'string' && dir.length > 0 && fs.existsSync(dir),

Check warning on line 34 in src/artifact-permissions.ts

View workflow job for this annotation

GitHub Actions / ESLint 

Found existsSync from package "fs" with non literal argument at index 0

Check warning on line 34 in src/artifact-permissions.ts

View workflow job for this annotation

GitHub Actions / Build and Lint (Node 22) 

Found existsSync from package "fs" with non literal argument at index 0

Check warning on line 34 in src/artifact-permissions.ts

View workflow job for this annotation

GitHub Actions / Build and Lint (Node 20) 

Found existsSync from package "fs" with non literal argument at index 0
);
if (existingDirs.length === 0) {
return;
Expand Down Expand Up @@ -62,15 +62,15 @@
'--cap-add',
'FOWNER',
'-e',
`TUID=${uid}`,

Check warning on line 65 in src/artifact-permissions.ts

View workflow job for this annotation

GitHub Actions / ESLint 

Avoid template literals with expressions in execa arguments. Pass arguments as separate array elements

Check warning on line 65 in src/artifact-permissions.ts

View workflow job for this annotation

GitHub Actions / Build and Lint (Node 22) 

Avoid template literals with expressions in execa arguments. Pass arguments as separate array elements

Check warning on line 65 in src/artifact-permissions.ts

View workflow job for this annotation

GitHub Actions / Build and Lint (Node 20) 

Avoid template literals with expressions in execa arguments. Pass arguments as separate array elements
'-e',
`TGID=${gid}`,

Check warning on line 67 in src/artifact-permissions.ts

View workflow job for this annotation

GitHub Actions / ESLint 

Avoid template literals with expressions in execa arguments. Pass arguments as separate array elements

Check warning on line 67 in src/artifact-permissions.ts

View workflow job for this annotation

GitHub Actions / Build and Lint (Node 22) 

Avoid template literals with expressions in execa arguments. Pass arguments as separate array elements

Check warning on line 67 in src/artifact-permissions.ts

View workflow job for this annotation

GitHub Actions / Build and Lint (Node 20) 

Avoid template literals with expressions in execa arguments. Pass arguments as separate array elements
'-v',
mount,
imageRef,
'sh',
'-c',
'chown -R "$TUID:$TGID" /fix && chmod -R a+rwX /fix',
'chown -R "$TUID:$TGID" /fix 2>/dev/null; chmod -R a+rwX /fix',
],
{ env: getLocalDockerEnv(), reject: false },
);
Expand Down
Loading