fix: propagate config fields to all layers#5809
Conversation
Add missing container.mounts CLI mapping entry to awf-config-spec.md. PR #5755 added container.mounts to the JSON schema, TypeScript types, and config-file.ts mapping, but the Section 5 CLI mapping table in docs/awf-config-spec.md was not updated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the AWF config specification documentation to reflect the missing CLI mapping for the newly-added container.mounts config field, improving consistency between config schema, mapper behavior, and docs.
Changes:
- Documented
container.mounts[]→-v, --mountCLI mapping indocs/awf-config-spec.md.
Show a summary per file
| File | Description |
|---|---|
| docs/awf-config-spec.md | Adds the missing CLI mapping entry for container.mounts[] to keep the config spec aligned with the schema/mapping layers. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Low
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
✅ Copilot review passed with no inline comments. @github-actions[bot] Add the |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
🔑 Smoke Copilot PAT PAT auth validated. All systems operational. ✅ |
|
✅ Build Test Suite completed successfully! |
|
✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓 |
|
✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓 |
|
🔌 Smoke Services — All services reachable! ✅ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
✅ Smoke Claude passed |
|
🚀 Security Guard has started processing this pull request |
|
✅ Contribution Check completed successfully! PR follows the applicable contribution guidelines; no comment needed. |
|
✅ Smoke Gemini completed. All facets verified. 💎 |
|
Chroot tests failed Smoke Chroot failed - See logs for details. |
Smoke Test: Claude Engine Validation
Overall Result: PASS ✅ Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
|
Tests: MCP ✅ GitHub.com ✅ File I/O ✅ BYOK ✅\nRunning direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL)\nOverall: PASS\n@lpcox Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test: Services Connectivity
Overall: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
🔬 Smoke Test: Copilot PAT Auth — PASS
Overall: PASS · Auth mode: PAT (COPILOT_GITHUB_TOKEN) · Author: Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test Results: Copilot BYOK (Direct) ✅
Status: PASS — Direct BYOK mode working via COPILOT_PROVIDER_API_KEY
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test Results
Overall status: FAIL Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "localhost"See Network Configuration for more information.
|
🔍 Smoke Test: Copilot Engine Validation
Overall: PASS ✅ Author: Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
|
Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) Tests:
Overall status: PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
|
Merged PRs: fix: chmod squid logs inside container before compose down; fix(ci): postprocess install-step swap must tolerate trailing --rootless flag | ✅ GitHub PR query | ✅ File write/read | ✅ Discussion lookup/comment | ✅ Build | ✅ GitHub title check via Chromium fallback | ❌ Playwright tool unavailable in this runner | Overall: FAIL Warning Firewall blocked 8 domainsThe following domains were blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "accounts.google.com"
- "awmgmcpg"
- "clients2.google.com"
- "contentautofill.googleapis.com"
- "images.ctfassets.net"
- "redirector.gvt1.com"
- "registry.npmjs.org"
- "www.google.com"See Network Configuration for more information.
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — ✅ PASS Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Smoke Test: API Proxy OpenTelemetry Tracing — Results
All 5 scenarios pass. OTEL tracing integration is fully functional. Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
network:
allowed:
- defaults
- "awmgmcpg"See Network Configuration for more information.
|
Config Consistency Fixes
Automated fixes for configuration fields not fully propagated across all required layers.
From PR #5755 — feat: add container.mounts to AWF config file schema
container.mountsdocs/awf-config-spec.md: maps to-v, --mount(repeatable)Root cause: PR #5755 correctly updated
src/awf-config-schema.json,docs/awf-config.schema.json,src/config-file.ts, andsrc/config-mapper.ts, but did not add the CLI mapping entry todocs/awf-config-spec.md.Verification
diff src/awf-config-schema.json docs/awf-config.schema.jsonproduces no outputtscpasses with no errorsconfig-file-mappingandschemasuitesWarning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
awmgmcpgSee Network Configuration for more information.