Skip to content

test: fix gvisor runtime matrix fixture - #6832

Merged
lpcox merged 1 commit into
mainfrom
fix-failing-tests
Aug 2, 2026
Merged

test: fix gvisor runtime matrix fixture#6832
lpcox merged 1 commit into
mainfrom
fix-failing-tests

Conversation

@lpcox

@lpcox lpcox commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • update the runtime matrix Docker mock to return newline-separated OCI runtime names
  • align the fixture with the bounded gVisor capability probe's docker info format

Validation

  • npm test -- --runInBand
  • npm run lint
  • npm run type-check
  • npm run build
  • npm run test:lint-rules

Return the newline-separated format requested by the bounded gVisor capability probe.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ffc77ba4-e473-4012-ab71-edc39ac6d167
Copilot AI review requested due to automatic review settings August 2, 2026 00:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the runtime matrix test fixture to match the gVisor capability probe’s newline-separated Docker runtime output.

Changes:

  • Replaces JSON runtime output with newline-separated OCI runtime names.
  • Includes both runc and runsc in the mock response.
Show a summary per file
File Description
src/bounded-query/runtime-matrix.test.ts Aligns the Docker runtime mock with the production probe format.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 98.79% 98.82% 📈 +0.03%
Statements 98.72% 98.74% 📈 +0.02%
Functions 99.02% 99.02% ➡️ +0.00%
Branches 95.11% 95.11% ➡️ +0.00%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/log-directory-setup.ts 96.2% → 100.0% (+3.78%) 96.3% → 100.0% (+3.71%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@lpcox
lpcox merged commit fa29bf0 into main Aug 2, 2026
27 checks passed
@lpcox
lpcox deleted the fix-failing-tests branch August 2, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants