Skip to content

feat: add Auth Doctor Updater workflow - #6898

Merged
lpcox merged 5 commits into
mainfrom
lpcox-create-auth-doctor
Aug 3, 2026
Merged

feat: add Auth Doctor Updater workflow#6898
lpcox merged 5 commits into
mainfrom
lpcox-create-auth-doctor

Conversation

@lpcox

@lpcox lpcox commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add a daily/manual Auth Doctor Updater modeled on the Self-Hosted Runner Doctor Updater
  • audit current AWF implementation, recent repository changes, and official OpenAI, Azure, AWS, GCP, Anthropic, Gemini, and GitHub authentication guidance
  • edit only an explicit allowlist of authentication/API-proxy documentation files and open one deduplicated pull request through gh-aw safe outputs, or noop when guidance is current
  • prohibit credential probes, token exchange, direct git/gh pr mutation, and changes outside the approved documentation allowlist
  • document the updater and clarify current-main API-proxy versus runner-owned mcpg OIDC boundaries

Validation

  • gh aw compile auth-doctor-updater --strict --validate --schedule-seed github/gh-aw-firewall
  • npm test -- --runInBand scripts/ci/auth-doctor-updater-workflow.test.ts
  • changed-file Markdown lint
  • npm run build
  • npm run lint
  • npm test -- --runInBand (305 suites, 5,359 passed, 1 skipped)
  • npm run docs:build
  • final credential-leakage, network, safe-output, generated-lock, and specialist security review

Limitations

The updater researches public implementation metadata and provider guidance; it does not inspect live credentials, exchange tokens, or call inference APIs. It treats PR #6894 and github/gh-aw#50053 as related rollout/compatibility work and verifies default-branch status before describing behavior as shipped.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 79dfde80-9308-4d73-bd34-3ec5bc114cd7
Copilot AI review requested due to automatic review settings August 3, 2026 18:40
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Documentation Preview

Documentation build failed for this PR. View logs.

Built from commit 2bb93c4

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 98.94% 98.97% 📈 +0.03%
Statements 98.83% 98.85% 📈 +0.02%
Functions 99.19% 99.19% ➡️ +0.00%
Branches 95.15% 95.15% ➡️ +0.00%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/log-directory-setup.ts 96.2% → 100.0% (+3.78%) 96.3% → 100.0% (+3.71%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a community-facing Auth Doctor workflow for credential-safe authentication and API-proxy diagnostics.

Changes:

  • Adds and compiles the /auth-doctor agentic workflow.
  • Covers static, BYOK, cloud OIDC, and MCP gateway authentication paths.
  • Updates authentication documentation and workflow validation.
Show a summary per file
File Description
.github/workflows/auth-doctor.md Defines the diagnostic workflow and safety playbook.
.github/workflows/auth-doctor.lock.yml Compiled workflow definition.
scripts/ci/auth-doctor-workflow.test.ts Validates workflow configuration and compilation.
README.md Links the workflow and authentication matrix.
docs/environment.md Documents OIDC environment boundaries.
docs/diagnosing-awf-failures.md Directs authentication failures to Auth Doctor.
docs/authentication-architecture.md Clarifies API-proxy and MCP OIDC trust paths.
docs/auth-matrix.md Adds Auth Doctor and OIDC guidance.
docs/api-proxy-sidecar.md Adds credential-safe troubleshooting guidance.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Suppressed comments (1)

.github/workflows/auth-doctor.md:137

  • These expected routes exclude the supported Copilot OIDC topology. The same Azure, AWS, and GCP providers can authenticate the Copilot adapter on port 10002 (docs/auth-matrix.md:165-173), so route diagnosis should distinguish both valid adapters instead of directing every setup to OpenAI/Vertex only. Update the route cells and regenerate the lock.
| Azure | `AWF_AUTH_AZURE_TENANT_ID`, `AWF_AUTH_AZURE_CLIENT_ID` | Azure OpenAI through the OpenAI adapter |
| AWS | `AWF_AUTH_AWS_ROLE_ARN`, `AWF_AUTH_AWS_REGION` | Bedrock with sidecar SigV4 signing |
| GCP | `AWF_AUTH_GCP_WORKLOAD_IDENTITY_PROVIDER`; service account optional | Vertex AI; optional service-account impersonation |
  • Files reviewed: 9/9 changed files
  • Comments generated: 5
  • Review effort level: Balanced

Comment thread scripts/ci/auth-doctor-workflow.test.ts Outdated
Comment thread .github/workflows/auth-doctor.md Outdated
Comment thread .github/workflows/auth-doctor.md Outdated
Comment thread .github/workflows/auth-doctor.md Outdated
Comment thread .github/workflows/auth-doctor.md Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 79dfde80-9308-4d73-bd34-3ec5bc114cd7
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

✅ Copilot review passed with no inline comments.

@lpcox Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

@lpcox lpcox changed the title feat: add Auth Doctor agentic workflow feat: add Auth Doctor Updater workflow Aug 3, 2026
lpcox added 3 commits August 3, 2026 12:02
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 79dfde80-9308-4d73-bd34-3ec5bc114cd7
Resolve authentication documentation conflicts against the shipped sidecar-only Actions OIDC isolation and regenerate the updater workflow lock.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 79dfde80-9308-4d73-bd34-3ec5bc114cd7
Use the available AJV release that avoids vulnerable fast-uri, and pin the docs build to a patched PostCSS release.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 79dfde80-9308-4d73-bd34-3ec5bc114cd7
@lpcox
lpcox merged commit af8ed0c into main Aug 3, 2026
26 checks passed
@lpcox
lpcox deleted the lpcox-create-auth-doctor branch August 3, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants