refactor: share sbx ingress capability writer - #6961
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
✅ Copilot review passed with no inline comments. @copilot Add the |
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (2 files)
✨ New Files (1 files)
Coverage comparison generated by |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
✅ Build Test Suite completed successfully! |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
|
🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅ |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
🔌 Smoke Services — All services reachable! ✅ |
|
✅ Contribution Check completed successfully! PR #6961 follows the contributing guidelines in the provided context: it adds tests for the new shared helper, keeps files under src/, and the PR description clearly explains the change and references Fixes #6952. No comment needed. |
|
🚀 Security Guard has started processing this pull request |
|
✅ Smoke Claude passed |
|
❌ Smoke Copilot BYOK AOAI (Entra) reports failed. AOAI BYOK (Entra) mode investigation needed... |
|
✅ Smoke Gemini completed. All facets verified. 💎 |
|
❌ Smoke Copilot BYOK AOAI (api-key) reports failed. AOAI BYOK (api-key) mode investigation needed... |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
📡 Smoke OTel Tracing reports failed. OTel tracing regression detected. OTel Tracing Smoke Test — all scenarios passed ✅
No regressions detected. No issue filed; run triggered outside a PR comment context (issue/PR numbers not set), so reporting via noop per instructions. |
|
📰 VERDICT: Smoke Docker Sbx has concluded. All systems operational. This is a developing story. 🎤 |
|
Smoke Test: Copilot BYOK (Direct) Mode Recent merged PRs (MCP connectivity ✅):
Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY) via api-proxy → api.githubcopilot.com Overall: PASS ✅ cc
|
Smoke Test: Claude Engine Validation
Overall Result: ✅ PASS
|
|
Smoke Test: Copilot Engine
Recent PRs: #6957 (Upgrade gh-aw to v0.85.0), #6951 (chore: model-to-API mapping) Overall: PASS cc
|
|
EGRESS_RESULT allow=pass deny=pass ✅ Allowed domain (github.com) reachable: Overall: PASS cc Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
Smoke Test: GitHub Actions Services Connectivity
Overall: FAIL All checks failed to resolve
|
🏗️ Build Test Suite Results
Overall: 8/8 ecosystems passed — PASS Note: Java builds required overriding Maven's local repository path (
|
Chroot Version Comparison
Overall: FAILED — Node.js version mismatch between host and chroot environment.
|
Smoke Test: Gemini Engine Validation
PR titles:
Overall status: FAIL
|
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
Smoke Test: Docker Sbx — PASS ✅
Overall: PASS cc
|
Bounded-agent and bounded-query each implemented the same security-sensitive capability file write path (
openSyncwith secure flags, write, chmod, close). This PR removes that duplication by centralizing the file creation/hardening flow in one shared helper while preserving behavior.What changed
src/bounded-agent/manager.tssrc/bounded-query/manager.tsSecurity-sensitive behavior preserved
O_WRONLY | O_CREAT | O_EXCL | O_NOFOLLOW0o600fchmodSync(fd, 0o600)before closecloseSyncinfinallyResult