Share bounded ingress conformance test harness - #6987
Conversation
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
There was a problem hiding this comment.
Review details
Suppressed comments (1)
src/test-helpers/ingress-conformance-test-harness.ts:43
- This test-only module does not match the build exclusion
**/*.test-utils.tsintsconfig.json:20, so it will be compiled and shipped with the productiondist, including its Jest-dependent harness. Please rename it toingress-conformance-test-harness.test-utils.tsand update both suite imports, consistent with the other helpers insrc/test-helpers/.
export function createIngressConformanceHarness(options: IngressConformanceHarnessOptions) {
- Files reviewed: 3/3 changed files
- Comments generated: 0 new
- Review effort level: Balanced
|
@copilot resolve merge conflicts |
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
|
✅ Copilot review passed with no inline comments. @copilot Add the |
|
📰 DEVELOPING STORY: Smoke Copilot reports failed to deliver outputs. Our correspondents are investigating the incident... |
|
❌ Smoke Claude failed to deliver outputs |
|
🛡️ Smoke Copilot Network Isolation reports failed to deliver outputs while checking network isolation. Investigate the egress model. |
|
✅ Build Test Suite completed successfully! |
|
Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded. |
|
✅ Contribution Check completed successfully! Contribution check complete: the provided review context did not include any changed-file patches, so I could not assess code style, tests, documentation updates, PR description quality beyond the metadata, or file organization. No review comment was added. |
|
❌ Smoke Copilot BYOK AOAI (Entra) reports failed to deliver outputs. AOAI BYOK (Entra) mode investigation needed... |
|
🔌 Smoke Services — All services reachable! ✅ |
|
📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅ |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
✅ Smoke Gemini completed. All facets verified. 💎 |
|
✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓 |
|
❌ Smoke Copilot BYOK AOAI (api-key) reports failed to deliver outputs. AOAI BYOK (api-key) mode investigation needed... Added smoke test PASS comment and label |
|
📰 DEVELOPING STORY: Smoke Docker Sbx reports failed to deliver outputs. Our correspondents are investigating the incident... |
|
🚀 Security Guard has started processing this pull request |
|
Smoke Test: Copilot Engine —
Overall: PASS
|
Smoke Test: Copilot BYOK (Direct) Mode — PASS ✅Running in direct BYOK mode via Results:
All 4 tests passed.
|
|
EGRESS_RESULT allow=pass deny=pass ✅ Allowed domain (api.github.com) reachable: Overall status: PASS
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "example.com"See Network Configuration for more information.
|
Smoke Test: Claude Engine Validation
Overall result: PASS
|
Chroot Version Comparison Results
Overall: FAILED — Node.js version differs between host and chroot environment.
|
|
Services connectivity smoke test:
Overall: FAIL —
|
Smoke Test: API Proxy OpenTelemetry Tracing — Results
Overall: All scenarios pass or are expected-pending. No issues found.
|
|
|
|
Recent PRs: chore: upgrade gh-aw to v0.86.0 pre-release and recompile workflows; fix(api-proxy): stop alias fallback picking arbitrary models MCP connectivity: ✅ Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra Overall: PASS cc
|
🏗️ Build Test Suite Results
Overall: 7/8 ecosystems passed — FAIL ❌ Java failure detailsBoth Root cause:
|
Smoke Test: Gemini Engine Validation
Overall Status: FAIL Note: GitHub MCP returned redacted results (#7064, #7036) due to secrecy policy. Network connectivity to github.com was blocked.
|
Smoke Test
Warning Firewall blocked 1 domainThe following domain was blocked by the firewall during workflow execution:
To allow these domains, add them to the network:
allowed:
- defaults
- "registry.npmjs.org"See Network Configuration for more information.
|
|
Docker Sbx Smoke Test
Pre-fetched PRs: #7027 "chore: upgrade gh-aw to v0.86.0 pre-release..." (merged), #6996 "fix(api-proxy): stop alias fallback..." (merged) Overall: PASS cc
|
Bounded-agent and bounded-query ingress conformance suites duplicated socket setup, broker stubs, request helpers, and transport-parity assertions. This refactor centralizes that security-relevant test harness while preserving broker-specific protocol expectations.
ingress-conformance-test-harness.tsfor Unix/TCP server lifecycle, broker recording, canonical responses, request helpers, and parity assertions.