refactor(logger): extract emit helper to eliminate Printf/Print duplication

[Copilot]

Logger.Printf and Logger.Print in internal/logger/logger.go shared ~20 lines of identical logic (mutex/time-diff, stderr output, file-logger write), differing only in how the message string was assembled.

Changes

• internal/logger/logger.go: Extract private emit(message string) that owns the shared block; Printf and Print now each check l.enabled then delegate with their respective format call:

func (l *Logger) emit(message string) {
    l.mu.Lock()
    now := time.Now()
    diff := now.Sub(l.lastLog)
    l.lastLog = now
    l.mu.Unlock()
    if l.color != "" {
        fmt.Fprintf(os.Stderr, "%s%s%s %s +%s\n", l.color, l.namespace, colorReset, message, strutil.FormatDuration(diff))
    } else {
        fmt.Fprintf(os.Stderr, "%s %s +%s\n", l.namespace, message, strutil.FormatDuration(diff))
    }
    LogDebug(l.namespace, "%s", message)
}

func (l *Logger) Printf(format string, args ...any) {
    if !l.enabled { return }
    l.emit(fmt.Sprintf(format, args...))
}

func (l *Logger) Print(args ...any) {
    if !l.enabled { return }
    l.emit(fmt.Sprint(args...))
}

Any future variants (Println, etc.) are now trivial to add correctly with a single emit call.

[Copilot]

Pull request overview

Refactors the debug Logger implementation to reduce duplicated logic between Printf and Print by extracting a shared internal helper, improving maintainability of stderr + file-logger emission behavior.

Changes:

• Extracts a private (*Logger).emit(message string) helper for the common “mutex/time-diff + stderr output + file logger write” block.
• Updates Logger.Printf and Logger.Print to early-return when disabled and delegate to emit with their respective message construction.

Show a summary per file

File	Description
internal/logger/logger.go	Deduplicates Printf/Print by extracting shared emission logic into emit.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 1/1 changed files
• Comments generated: 1

[lpcox]

@copilot address review feedback

[Copilot]

@copilot address review feedback

Addressed in b6827db. The logger now captures the time diff before formatting, preserving the original +<diff> behavior, and I added a regression test covering slow formatting for both Print and Printf.