Refactor duplicated []string→[]interface{} conversions into strutil.StringsToAny#7990
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Refactor duplicate []string to []interface{} conversion
Refactor duplicated Jun 23, 2026
[]string→[]interface{} conversions into strutil.StringsToAny
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces duplicated boilerplate by centralizing []string → []interface{} conversions into a shared internal/strutil.StringsToAny helper, then updating guard/config code paths to use it.
Changes:
- Added
strutil.StringsToAny([]string) []interface{}as the canonical conversion helper. - Replaced repeated inline conversion loops in guard label-agent payload building and guard policy normalization.
- Added a focused unit test covering conversion behavior.
Show a summary per file
| File | Description |
|---|---|
internal/strutil/strutil.go |
Adds the new shared StringsToAny conversion helper. |
internal/strutil/strings_to_any_test.go |
Introduces unit tests for StringsToAny behavior. |
internal/guard/wasm_payload.go |
Replaces inline []string→[]interface{} loops for trusted-bots/users with StringsToAny. |
internal/config/guard_policy_validation.go |
Uses StringsToAny when normalizing allow-only.repos provided as []string. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes three repeated inline conversion loops that transformed
[]stringinto[]interface{}in guard/config paths. The conversion is now centralized to reduce boilerplate and keep future behavior changes in one place.New shared utility
StringsToAny([]string) []interface{}ininternal/strutil/strutil.go.Guard payload cleanup
BuildLabelAgentPayload(internal/guard/wasm_payload.go) for:trusted-botstrusted-usersstrutil.StringsToAny(...).Guard policy normalization cleanup
[]stringscope conversion ininternal/config/guard_policy_validation.gowithstrutil.StringsToAny(scope)beforenormalizeAndValidateScopeArray(...).Focused coverage for helper
internal/strutil/strings_to_any_test.gocovering: