[log] tracing: add debug logging to config_resolver.go#8306
Merged
Conversation
Add logTracing.Printf calls to three functions in config_resolver.go that previously had no logging: - resolveEndpoint: log input endpoint/signalPath, URL-parse fallback path, and resolved result - resolveServiceName: log when using a configured service name - resolveCommaSeparatedExtraEndpoints: log count of valid endpoints parsed Uses the existing package-level logTracing logger (declared in provider.go). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional debug-level tracing logs in the OTLP configuration resolver to make endpoint/service-name resolution and extra-endpoint parsing easier to troubleshoot when DEBUG enables the existing tracing:provider logger.
Changes:
- Log
resolveEndpointinputs, the string-fallback path when URL parsing fails, and the final resolved endpoint. - Log when a configured tracing service name is used (vs. default).
- Log how many valid extra endpoints were parsed from
GH_AW_OTLP_ENDPOINTS(comma-separated form), with a small refactor to storestrings.Splitresults inparts.
Show a summary per file
| File | Description |
|---|---|
| internal/tracing/config_resolver.go | Adds debug logging around OTLP endpoint/service-name resolution and extra-endpoint parsing to improve diagnosability when tracing config is mis-specified. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
This was referenced Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds 5
logTracing.Printfcalls tointernal/tracing/config_resolver.gofor three previously-unlogged functions, using the package-level logger already declared inprovider.go.Changes
resolveEndpointendpointandsignalPathat function entryresolveServiceNameresolveCommaSeparatedExtraEndpointsstrings.Splitresult intoparts(no functional change)Validation
go vet ./internal/tracing/...— cleango test ./internal/tracing/...— all tests passgo build— binary compiles successfullyNo new imports required;
logTracingis the existing package-level logger fromprovider.go.