refactor: extract newValidationError helper to deduplicate log+return pattern in validation functions

[Copilot]

14 validation functions across validation_errors.go and validation_rules.go independently called logValidation.Printf then returned a &ValidationError{...} literal — meaning any log format change required editing every call site.

Changes

internal/config/validation_errors.go — new private helper:

func newValidationError(logMsg, field, message, jsonPath, suggestion string) *ValidationError {
    logValidation.Printf("%s", logMsg)
    return &ValidationError{Field: field, Message: message, JSONPath: jsonPath, Suggestion: suggestion}
}

• Pattern B (UnsupportedType, UndefinedVariable, MissingRequired, InvalidPattern, SchemaValidationError): each had an identical log-then-return body; all five now delegate to the helper.

internal/config/validation_rules.go

• Pattern A (PortRange, PositiveInteger, TimeoutMinimum, TimeoutRange, AbsolutePath): per-function entry logs are retained as-is (they vary by parameters), but each failure-log + &ValidationError{} block is replaced with a single newValidationError(...) call.

No validation error messages, field values, or public API changed.

[Copilot]

Pull request overview

This PR refactors config validation code by extracting a shared newValidationError helper to centralize the repeated “log + construct *ValidationError” pattern, reducing duplication across validation helpers in internal/config.

Changes:

• Added a private newValidationError(logMsg, field, message, jsonPath, suggestion) helper to log and construct *ValidationError.
• Updated several validation error constructors in validation_errors.go to delegate to the helper.
• Updated several rule validators in validation_rules.go to replace inline “log + &ValidationError{...}” blocks with newValidationError(...) calls while preserving entry logs.

Show a summary per file

File	Description
internal/config/validation_errors.go	Introduces newValidationError and migrates multiple error constructors to use it.
internal/config/validation_rules.go	Replaces repeated failure “log + return ValidationError” blocks with newValidationError(...) calls in several validators.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Low