refactor(logger): extract syncFileWithWarning to eliminate duplicated sync boilerplate

[Copilot]

FileLogger.Log() and ServerFileLogger.Log() both inlined the same three-step pattern: call file.Sync(), and on failure emit log.Printf("WARNING: Failed to sync log file..."). Any future change to sync behavior (throttling, retry, warning format) had to be applied twice.

Changes

• internal/logger/global_helpers.go — adds syncFileWithWarning(file *os.File, context string): nil-guards the file, syncs it, and logs a warning to stderr on failure. The context parameter (e.g. " for server github") lets both call sites produce their original distinct warning messages.
• internal/logger/file_logger.go — replaces the inline if logFile != nil { Sync/warn } block with syncFileWithWarning(fl.logFile, "").
• internal/logger/server_file_logger.go — replaces the inline if file, exists := sfl.files[serverID]; exists { Sync/warn } block with syncFileWithWarning(sfl.files[serverID], " for server "+serverID). Go's zero-value map lookup (nil for a missing *os.File) is handled by the helper's nil guard, preserving identical behaviour.

[Copilot]

Pull request overview

This PR refactors the logger package to remove duplicated “sync log file + warn on failure” boilerplate by introducing a shared helper used by both the unified file logger and the per-server file logger.

Changes:

• Added syncFileWithWarning(file *os.File, context string) helper to centralize file sync + warning emission and to nil-guard missing files.
• Updated FileLogger.Log() to use the helper instead of inlining the sync/warn block.
• Updated ServerFileLogger.Log() to use the helper, preserving the existing per-server warning context.

Show a summary per file

File	Description
internal/logger/global_helpers.go	Adds the shared syncFileWithWarning helper (nil-guard + sync + stderr warning) to centralize behavior.
internal/logger/file_logger.go	Replaces inline sync/warn logic with syncFileWithWarning(fl.logFile, "").
internal/logger/server_file_logger.go	Replaces inline sync/warn logic with syncFileWithWarning(sfl.files[serverID], " for server "+serverID).

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 3/3 changed files
• Comments generated: 0
• Review effort level: Low