[review] fix: rootless AWF install uses $HOME/.local and exports $GITHUB_PATH#41321
Merged
pelikhan merged 9 commits intoJun 24, 2026
Merged
Conversation
- Retarget AWF_INSTALL_DIR/AWF_LIB_DIR to $HOME/.local/{bin,lib/awf} in
rootless mode so standard GitHub-hosted runners (root-owned /usr/local)
work without pre-chowning or sudo
- Replace the erroring rootless preflight with mkdir+verify so user dirs
are created on demand
- Fix bundle wrapper to use ${AWF_LIB_DIR} instead of hardcoded
/usr/local/lib/awf so the wrapper finds awf-bundle.js in the right place
- Export $GITHUB_PATH after rootless install so the bare awf invocation in
later steps resolves correctly
- Update comment in copilot_engine_installation.go to reflect new behavior
Closes #41309
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
The export PATH line in rootless mode was redundant: GitHub Actions
subsequent steps inherit PATH additions only via $GITHUB_PATH (not shell
exports), and the --version check at the end of the script already uses
the full path ${AWF_INSTALL_DIR}/${AWF_INSTALL_NAME} directly.
Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
…paths Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>
…nary_test.sh Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…' into copilot/fix-rootless-awf-install Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
This was referenced Jun 24, 2026
pelikhan
deleted the
copilot/fix-rootless-awf-install-review-1782344030882
branch
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.
Details
Potential security threats were detected in the agent output.
Review the workflow run logs for details.
test body