-
Notifications
You must be signed in to change notification settings - Fork 429
chore: set sandbox.agent.sudo: false on 30% of agentic workflows #41380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,7 +61,7 @@ features: | |
| gh-aw-detection: true | ||
| sandbox: | ||
| agent: | ||
| sudo: true | ||
| sudo: false | ||
| --- | ||
|
|
||
| # AI Moderator | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,7 +61,7 @@ features: | |
| gh-aw-detection: true | ||
| sandbox: | ||
| agent: | ||
| sudo: true | ||
| sudo: false | ||
| --- | ||
| # Blog Auditor | ||
|
|
||
|
|
||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,7 +54,7 @@ imports: | |
| - shared/otlp.md | ||
| sandbox: | ||
| agent: | ||
| sudo: true | ||
| sudo: false | ||
| --- | ||
|
|
||
| # Changeset Generator | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ network: | |
| sandbox: | ||
| agent: | ||
| id: awf | ||
| sudo: true | ||
| sudo: false | ||
| tools: | ||
| cli-proxy: true | ||
| agentic-workflows: | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -47,7 +47,7 @@ steps: | |
|
|
||
| sandbox: | ||
| agent: | ||
| sudo: true | ||
| sudo: false | ||
| --- | ||
|
|
||
| # Dead Code Removal Agent | ||
|
|
||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,7 @@ timeout-minutes: 10 | |
|
|
||
| sandbox: | ||
| agent: | ||
| sudo: true | ||
| sudo: false | ||
| --- | ||
|
|
||
| # Deployment Incident Monitor | ||
|
|
||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,7 +36,7 @@ tools: | |
|
|
||
| sandbox: | ||
| agent: | ||
| sudo: true | ||
| sudo: false | ||
| --- | ||
|
|
||
| <!-- | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ imports: | |
| - shared/otlp.md | ||
| sandbox: | ||
| agent: | ||
| sudo: true | ||
| sudo: false | ||
| --- | ||
| # Weekly Workflow Analysis | ||
|
|
||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -88,7 +88,7 @@ steps: | |
|
|
||
| sandbox: | ||
| agent: | ||
| sudo: true | ||
| sudo: false | ||
| --- | ||
|
|
||
| # Glossary Maintainer | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,7 +46,7 @@ tools: | |
| - default | ||
| sandbox: | ||
| agent: | ||
| sudo: true | ||
| sudo: false | ||
| --- | ||
| # Instructions Janitor | ||
|
|
||
|
|
||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,7 +46,7 @@ strict: true | |
|
|
||
| sandbox: | ||
| agent: | ||
| sudo: true | ||
| sudo: false | ||
| --- | ||
|
|
||
| # jsweep - JavaScript Unbloater | ||
|
|
||
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,7 +63,7 @@ steps: | |
|
|
||
| sandbox: | ||
| agent: | ||
| sudo: true | ||
| sudo: false | ||
| --- | ||
|
|
||
| # Mergefest - Merge Main into Pull Request Branch | ||
|
|
||
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,7 +61,7 @@ pre-agent-steps: | |
| fi | ||
| sandbox: | ||
| agent: | ||
| sudo: true | ||
| sudo: false | ||
| --- | ||
|
|
||
| # Outcome Collector | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[/zoom-out] The single-line source change is the right level of abstraction here — the
.mdfile is the source of truth andsudo: falseaccurately captures the intent. Worth noting for reviewers that the compiled lock reflects a full rootless mode migration: rootless install, bridge networking, container name addressing, andisolation:truein the firewall config. None of this needs to be in the.md— it is all a compiler concern — but it is useful context when reading the diff.💡 What rootless mode changes in the compiled lock
install_awf_binary.sh v0.27.10 --rootless— installs the rootless variant of the AWF container runtime--network host→--network bridge -p 127.0.0.1:PORT:PORT— better container isolationhost.docker.internal→awmg-mcpg(container name on bridge)host.docker.internal:18443→awmg-cli-proxy:18443awf-config.jsongains"isolation":true,"topologyAttach":["awmg-mcpg","awmg-cli-proxy"]sudo -E awf→awf, and thesudo chmod -R a+rXcleanup step is removed