Skip to content

fix: revert sandbox.agent.sudo to true in glossary-maintainer workflow#41426

Merged
pelikhan merged 2 commits into
mainfrom
copilot/aw-glossary-maintainer-failed
Jun 25, 2026
Merged

fix: revert sandbox.agent.sudo to true in glossary-maintainer workflow#41426
pelikhan merged 2 commits into
mainfrom
copilot/aw-glossary-maintainer-failed

Conversation

Copilot AI commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Commit 44bc1b75 ("chore: set sandbox.agent.sudo: false on 30% of agentic workflows") broke the Glossary Maintainer workflow — the agent step failed with exit code 1 and artifact upload failed with EACCES on firewall log files.

What broke in non-sudo mode

  • Networking regression: sudo -E awf ... --enable-host-access --allow-host-ports 80,443,8080 --difc-proxy-host host.docker.internal:18443awf ... --difc-proxy-host awmg-cli-proxy:18443, changing the firewall network topology and causing agent startup failure.
  • Permission regression: The sudo chmod -R a+rX /tmp/gh-aw/sandbox/firewall step was removed. Firewall Docker containers still write root-owned files to the host volume, so the runner user hits EACCES when the artifact upload tries to zip them.

Fix

Reverts sandbox.agent.sudo: false → true in glossary-maintainer.md and recompiles. This restores sudo -E awf with the correct host-access flags and the chmod permission-fix step.

 sandbox:
   agent:
-    sudo: false
+    sudo: true

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title [WIP] Debug workflow failure for glossary maintainer fix: revert sandbox.agent.sudo to true in glossary-maintainer workflow Jun 25, 2026
Copilot AI requested a review from pelikhan June 25, 2026 12:40
@pelikhan pelikhan marked this pull request as ready for review June 25, 2026 12:41
Copilot AI review requested due to automatic review settings June 25, 2026 12:41
@pelikhan pelikhan merged commit 45ba446 into main Jun 25, 2026
@pelikhan pelikhan deleted the copilot/aw-glossary-maintainer-failed branch June 25, 2026 12:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request restores the Glossary Maintainer agentic workflow’s ability to run successfully by reverting it back to sudo-enabled sandbox execution, and recompiling the generated workflow lockfile so the runtime wiring matches the restored sandbox mode.

Changes:

  • Revert sandbox.agent.sudo from false to true in glossary-maintainer.md.
  • Recompile glossary-maintainer.lock.yml, restoring the sudo-based AWF invocation (including host-access flags) and the firewall log permission fix-up to prevent artifact upload EACCES.
Show a summary per file
File Description
.github/workflows/glossary-maintainer.md Re-enables sandbox.agent.sudo: true for the workflow’s sandboxed agent execution.
.github/workflows/glossary-maintainer.lock.yml Updates the compiled workflow to match sudo mode (AWF install/run flags, MCP gateway networking, and firewall log chmod before artifact upload).

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 2/2 changed files
  • Comments generated: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants