Skip to content

Issue Monster: eliminate false-positive 429 rate-limit detection#41471

Merged
pelikhan merged 2 commits into
mainfrom
copilot/fix-429-detection
Jun 25, 2026
Merged

Issue Monster: eliminate false-positive 429 rate-limit detection#41471
pelikhan merged 2 commits into
mainfrom
copilot/fix-429-detection

Conversation

Copilot AI commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Issue Monster was treating unrelated text as a 429 signal and prematurely skipping issue assignment. In practice, PR metadata like #41429 matched the old pattern and triggered the rate-limit guard incorrectly.

  • Problem scope

    • Pre-activation rate-limit detection in issue-monster comment scanning was too broad.
    • Any substring containing 429 could be interpreted as a real HTTP 429 indicator.
  • Change

    • Tightened the detection regex to require a standalone 429 token instead of arbitrary substring matches.
    • Applied the change in the workflow source and regenerated the compiled lock workflow.
  • Behavioral impact

    • Keeps detection for actual rate-limit markers (429, rate limit, secondary rate limit, abuse detection, too many requests).
    • Stops false positives from numeric fragments in unrelated text (e.g., PR numbers).
// before
const rateLimitPattern = /rate limit|API rate limit|secondary rate limit|abuse detection|429|too many requests/i;

// after
const rateLimitPattern = /rate limit|API rate limit|secondary rate limit|abuse detection|\b429\b|too many requests/i;

Copilot AI and others added 2 commits June 25, 2026 14:18
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Fix over-aggressive 429 detection in Issue Monster Issue Monster: eliminate false-positive 429 rate-limit detection Jun 25, 2026
Copilot AI requested a review from pelikhan June 25, 2026 14:25
@pelikhan pelikhan marked this pull request as ready for review June 25, 2026 14:28
Copilot AI review requested due to automatic review settings June 25, 2026 14:28
@pelikhan pelikhan merged commit 8a2150d into main Jun 25, 2026
@pelikhan pelikhan deleted the copilot/fix-429-detection branch June 25, 2026 14:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens Issue Monster’s rate-limit detection so it no longer treats arbitrary “429” substrings (e.g., PR numbers like #41429) as a real HTTP 429/rate-limit signal, preventing premature skipping of issue assignment.

Changes:

  • Update issue-monster comment-scanning regex to require a standalone 429 token (\b429\b).
  • Regenerate issue-monster.lock.yml to reflect the updated workflow source.
  • Regenerate Copilot smoke lock workflows, including changing compiled strict-mode reporting to false.
Show a summary per file
File Description
.github/workflows/smoke-copilot.lock.yml Regenerated lock file; changes compiled strict-mode flag to false.
.github/workflows/smoke-copilot-aoai-entra.lock.yml Regenerated lock file; changes compiled strict-mode flag to false.
.github/workflows/issue-monster.md Tightens rate-limit regex to avoid false-positive 429 substring matches.
.github/workflows/issue-monster.lock.yml Regenerated lock file to incorporate the updated Issue Monster regex.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 4/4 changed files
  • Comments generated: 2

GH_AW_INFO_FIREWALL_TYPE: "squid"
GH_AW_INFO_FRONTMATTER_EMOJI: "🧪"
GH_AW_COMPILED_STRICT: "true"
GH_AW_COMPILED_STRICT: "false"
GH_AW_INFO_FIREWALL_TYPE: "squid"
GH_AW_INFO_FRONTMATTER_EMOJI: "🧪"
GH_AW_COMPILED_STRICT: "true"
GH_AW_COMPILED_STRICT: "false"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants