Skip to content

Fix: apply gh-aw actionlint ignore patterns in compile path #42672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Jul 1, 2026
Merged

Fix: apply gh-aw actionlint ignore patterns in compile path #42672

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7317e5d
Initial plan
Copilot Jul 1, 2026
50badd1
Fix: pass defaultGhAwActionlintIgnorePatterns in runActionlintOnFiles…
Copilot Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/cli/actionlint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ func runActionlintOnFiles(ctx context.Context, lockFiles []string, verbose bool,
return runActionlintOnFilesWithOptions(ctx, lockFiles, verbose, strict, actionlintRunOptions{
IncludeShellcheck: true,
IncludePyflakes: true,
IgnorePatterns: defaultGhAwActionlintIgnorePatterns,

@github-actions github-actions Bot Jul 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[/tdd] No regression test guards this compile path — if IgnorePatterns were accidentally dropped again, no test would catch it.

💡 Suggested regression test

The existing TestNewLintCommand in lint_command_test.go verifies that defaultGhAwActionlintIgnorePatterns contains the expected patterns, but nothing verifies that runActionlintOnFiles (the compile wrapper) actually forwards them to runActionlintOnFilesWithOptions.

A lightweight guard — for example a test that injects a fake runner and asserts options.IgnorePatterns == defaultGhAwActionlintIgnorePatterns — would prevent the compile/lint drift that caused 426 false-positive findings:

// TestRunActionlintOnFilesUsesDefaultIgnorePatterns guards the compile path
// against a repeat of the missing-IgnorePatterns regression (PR #42672).
func TestRunActionlintOnFilesUsesDefaultIgnorePatterns(t *testing.T) {
    var captured actionlintRunOptions
    // inject a stub runner that records the options, then call runActionlintOnFiles
    // and assert captured.IgnorePatterns == defaultGhAwActionlintIgnorePatterns
}

@copilot please address this.

})
}

Expand Down
Loading