Skip to content

[review] Compiler: redirect DOTNET_INSTALL_DIR and GOPATH for ARC/DinD topology#42861

Closed
github-actions[bot] wants to merge 8 commits into
mainfrom
fix/arc-dind-runtime-install-paths-review-1782953223231
Closed

[review] Compiler: redirect DOTNET_INSTALL_DIR and GOPATH for ARC/DinD topology#42861
github-actions[bot] wants to merge 8 commits into
mainfrom
fix/arc-dind-runtime-install-paths-review-1782953223231

Conversation

@github-actions

@github-actions github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Caution

agentic threat detected
Threat detection flagged this output in warn mode. Manual review is REQUIRED before any follow-up automation.

Reason: agent_failure

Review the workflow run logs for details.

This PR contains changes that were originally intended for PR #42855 (fix/arc-dind-runtime-install-paths).
Please review the changes carefully before merging.


Generated by 👨‍🍳 PR Sous Chef · 17.5 AIC · ⌖ 10.4 AIC · ⊞ 4K ·


Generated by 👨‍🍳 PR Sous Chef · 5.87 AIC · ⌖ 21.7 AIC · ⊞ 6.4K ·

lpcox added 3 commits July 1, 2026 17:31
On ARC/DinD runners, setup-dotnet installs to /usr/share/dotnet by default
which requires root permissions. Similarly, GOPATH defaults to a path that
may not be writable or visible to the DinD daemon.

Extend the existing 'Redirect tool cache for ARC/DinD' step to also set:
- DOTNET_INSTALL_DIR -> ${RUNNER_TEMP}/gh-aw/tool-cache/dotnet
- GOPATH -> ${RUNNER_TEMP}/gh-aw/tool-cache/go

This ensures all runtime setup actions install to daemon-visible, writable paths.

Fixes the 'mkdir: cannot create directory /usr/share/dotnet: Permission denied'
error seen in ARC/DinD canary workflows.

Related: #42807
Base automatically changed from fix/arc-dind-runtime-install-paths to main July 2, 2026 05:03
@pelikhan

pelikhan commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

@lpcox still relevant?

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill and check whether this review PR still needs action. Confirm the branch still represents the intended follow-up for PR #42855, refresh it after the branch update, and either finish any remaining work or summarize why it can be closed.

Run: https://github.com/github/gh-aw/actions/runs/28592810254

Generated by 👨‍🍳 PR Sous Chef · 17.5 AIC · ⌖ 10.4 AIC · ⊞ 4K ·

Copilot AI commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@copilot please run the pr-finisher skill and check whether this review PR still needs action. Confirm the branch still represents the intended follow-up for PR #42855, refresh it after the branch u...

I ran the PR-finisher triage.

No additional code changes were needed from me in this pass. If we still want the release-note entry for #42855, this PR remains relevant; if not, it can be closed as no longer needed.

Copilot AI requested a review from gh-aw-bot July 2, 2026 13:34
@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill, address unresolved review comments, and rerun checks once the branch is up to date.

Generated by 👨‍🍳 PR Sous Chef · 5.87 AIC · ⌖ 21.7 AIC · ⊞ 6.4K ·

Copilot AI and others added 2 commits July 2, 2026 14:19
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@copilot please run the pr-finisher skill, address unresolved review comments, and rerun checks once the branch is up to date.

...

Done. I re-ran PR-finisher triage on this branch:

  • No unresolved review threads/comments to address.
  • Branch is up to date with main (PR base SHA 281d68a).
  • I inspected recent workflow runs and failed-job logs via MCP; the action_required Smoke CI runs have zero jobs/failures.

I also fixed an unintended workflow lockfile drift introduced during this pass in commit 7f78676.

CI for the latest head still needs a maintainer-triggered rerun (agent pushes do not auto-trigger workflows).

@gh-aw-bot

Copy link
Copy Markdown
Collaborator

@copilot please run the pr-finisher skill and re-check whether this follow-up PR still needs to stay open. If it is still needed, leave a concise maintainer-facing summary of what remains; if not, explain clearly why it can be closed. Also confirm whether any checks need a rerun after the latest branch state.

Run: https://github.com/github/gh-aw/actions/runs/28611171544

Generated by 👨‍🍳 PR Sous Chef · 19.4 AIC · ⌖ 16.2 AIC · ⊞ 6.4K ·

Copilot AI and others added 2 commits July 2, 2026 18:15
Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>
This reverts commit e962868.

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot AI commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@copilot please run the pr-finisher skill and re-check whether this follow-up PR still needs to stay open. If it is still needed, leave a concise maintainer-facing summary of what remains; if not, e...

Rechecked with pr-finisher.

This follow-up PR should stay open if we still want the missing release-note entry for #42855: the PR now contains only .changeset/patch-arc-dind-runtime-installs.md (no code/workflow deltas beyond that). If that changeset is not needed, the PR can be closed.

Maintainer-facing remainder: decide whether to keep that changeset entry.

Checks: yes, a rerun is still needed on the latest head (92251d2). Current PR-head check state is pending with no completed check runs; the latest Smoke CI run (28612226400) is action_required with zero jobs/failures. A maintainer-triggered rerun is required to get fresh CI signal on current head.

@pelikhan pelikhan closed this Jul 2, 2026
@github-actions github-actions Bot added the closed:unknown PR was closed without merging: unknown label Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

closed:unknown PR was closed without merging: unknown needs-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants