Handle braceless core.setFailed() control-flow in require-return-after-core-setfailed

[Copilot]

require-return-after-core-setfailed was missing direct single-statement control bodies, so braceless if/else branches and loop bodies could call core.setFailed() and still fall through without being diagnosed. The gap was positional: the braced form was reported, while the equivalent braceless form was not.

• Expand continuation analysis

  • Analyze core.setFailed() when it is the direct braceless body of:
    • if / else
    • while
    • do...while
    • for
    • for...in
    • for...of
  • Reuse the existing continuation search so these forms are treated consistently with braced blocks and existing loop back-edge handling.

• Keep fixer output syntactically correct

  • When the reported setFailed() is a direct braceless control body, the addReturn suggestion now wraps it in a block before inserting return;.
  • This preserves control-flow association and avoids detached fixes like:

    if (bad) core.setFailed("x"); return;

• Add focused regression coverage

  • Invalid cases for braceless:
    • if with following continuation
    • if/else with following continuation
    • loop bodies with continuation
    • recognized callee variants (core.setFailed, core["setFailed"], alias, destructured binding)
  • Valid case for terminal braceless if with no continuation.

Example:

function f() {
  if (bad) core.setFailed("x");
  doMore();
}

Suggested fix:

function f() {
  if (bad) { core.setFailed("x"); return; }
  doMore();
}

[Copilot]

Pull request overview

Extends the ESLint rule to detect fall-through after braceless core.setFailed() control bodies and provide block-wrapping fixes.

Changes:

• Adds direct if and loop-body analysis.
• Adds fixer handling and regression tests for braceless bodies.

Show a summary per file

File	Description
require-return-after-core-setfailed.ts	Adds detection and suggestions for braceless control bodies.
require-return-after-core-setfailed.test.ts	Adds braceless control-flow regression cases.

Review details

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 3
• Review effort level: Medium