Honor repositories: ["*"] in activation GitHub App token minting#45908
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
repositories: ["*"] in activation GitHub App token minting
|
@copilot update the safe outputs specification with w3c-spec-writer |
There was a problem hiding this comment.
Pull request overview
Updates activation GitHub App token minting to honor wildcard and explicit repository scopes.
Changes:
- Omits
repositoriesfor["*"], enabling installation-wide access. - Supports single, multiple, and default repository scopes.
- Adds regression coverage and refreshes AWF v0.27.35 pins/workflows.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/safe_outputs_app_config.go |
Implements activation repository scoping. |
pkg/workflow/activation_github_token_test.go |
Tests wildcard omission. |
pkg/workflow/data/action_pins.json |
Reorders AWF v0.27.35 pins. |
pkg/actionpins/data/action_pins.json |
Mirrors updated pins. |
.github/workflows/smoke-ci.lock.yml |
Regenerates with AWF v0.27.35. |
.github/workflows/firewall.lock.yml |
Regenerates with AWF v0.27.35. |
.github/workflows/example-permissions-warning.lock.yml |
Regenerates with AWF v0.27.35. |
.github/workflows/daily-malicious-code-scan.lock.yml |
Regenerates with AWF v0.27.35. |
.github/workflows/codex-github-remote-mcp-test.lock.yml |
Regenerates with AWF v0.27.35. |
.github/workflows/bot-detection.lock.yml |
Regenerates with AWF v0.27.35. |
.github/workflows/ai-moderator.lock.yml |
Regenerates with AWF v0.27.35. |
.github/workflows/agentic-token-optimizer.lock.yml |
Regenerates with AWF v0.27.35. |
.github/workflows/ace-editor.lock.yml |
Regenerates with AWF v0.27.35. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 33/261 changed files
- Comments generated: 0
- Review effort level: Medium
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Addressed in 3d5f311. Updated the safe outputs specification with a new normative |
|
@copilot merge main and recompile |
…ivation-token-scope # Conflicts: # .github/workflows/avenger.lock.yml # .github/workflows/hourly-ci-cleaner.lock.yml # .github/workflows/skillet.lock.yml Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
@copilot merge main and recompile |
Done — merged main and recompiled all 257 workflows successfully (9ae29dc). The only test failures ( |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…ter package update Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Fixed in the latest commit. The CI failure was caused by the
All |
|
@copilot merge main and recompile |
…ivation-token-scope # Conflicts: # pkg/actionpins/actionpins_internal_test.go # pkg/actionpins/spec_test.go # pkg/workflow/action_pins_test.go # pkg/workflow/awf_helpers_test.go # pkg/workflow/docker_firewall_pin_compile_test.go # pkg/workflow/docker_pin_test.go Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done — merged main and recompiled all 257 workflows successfully (0 errors). Resolved test conflicts by adopting main's constants-based approach ( |
|
🎉 This pull request is included in a new release. Release: |
Activation GitHub App token minting did not honor the
repositories: ["*"]sentinel. In reusableworkflow_callflows, the activation job always scoped the token togithub.event.repository.name, which broke cross-repo access needed to read the callee repo’s agent configuration.Compiler behavior
buildActivationAppTokenMintStepto match the existing GitHub App token minting behavior used elsewhere:repositories:whenrepositories: ["*"]github.event.repository.nameonly when no repositories are configuredRegression coverage
activation-app-tokenstep does not include arepositories:input when the wildcard sentinel is configuredBehavioral effect
repositories: ["*"]now yields org-wide installation token scope for activation steps, instead of incorrectly forcing caller-repo scopeWith this change, the generated activation token step omits:
so the token can access any repository where the App is installed.