Skip to content

Harden AWF downloads and digest-pinned MCP startup - #53201

Closed
pelikhan with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-install-awf-binary
Closed

Harden AWF downloads and digest-pinned MCP startup#53201
pelikhan with Copilot wants to merge 2 commits into
mainfrom
copilot/fix-install-awf-binary

Conversation

Copilot AI commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Transient release-download failures could abort evals, while MCP Gateway rejected valid digest-pinned container images. Missing evals artifacts then produced misleading downstream errors.

  • AWF installation

    • Centralize release downloads behind retry/backoff handling.
    • Report an explicit network error when retries are exhausted.
  • MCP Gateway

    • Accept image[:tag]@sha256:<64-hex> container references.
    • Keep runtime and published schemas synchronized.
  • Evals reporting

    • Continue when the upstream evals artifact is absent.
    • Emit a clear notice that evals were skipped or failed upstream.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Hey 👋 — thanks for tackling this infrastructure reliability issue! The PR is well-anchored to issue #53191 with clear success criteria. Here are a few things to clarify as you move forward:

  • Scope clarity — Issue [aw-failures] [P1] Two new job-failure root causes: AWF binary curl reset in Daily SPDD evals + MCP Gateway serena digest-pin sc [Content truncated due to length] #53191 describes two separate fixes: (1) shell script retry logic for curl, and (2) MCP Gateway schema validation for digest-pinned images. Your PR title focuses on the first. Please clarify in the PR body whether you're addressing both in this single PR or splitting them.
  • Add tests — Once you implement the retry logic, add shell script tests (or update existing install_awf_binary.sh test coverage) to verify the retry behavior under simulated transient failures.
  • Targeted tests and manual verification — Your checklist mentions "Run targeted tests and manual verification" as a task — make sure those are completed and their results documented before marking this ready for review.

The plan looks solid. Looking forward to seeing the implementation!

Generated by ✅ Contribution Check · auto · 47.7 AIC · ⌖ 3.22 AIC · ⊞ 9.1K ·

Copilot AI changed the title [WIP] Fix install_awf_binary.sh to retry on transient curl failures Harden AWF downloads and digest-pinned MCP startup Aug 16, 2026
Copilot AI requested a review from pelikhan August 16, 2026 21:02
@pelikhan pelikhan closed this Aug 16, 2026
@github-actions
github-actions Bot deleted the copilot/fix-install-awf-binary branch August 25, 2026 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants