-
Notifications
You must be signed in to change notification settings - Fork 499
Relax approval gating for low-risk PR automations #53480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
4e79656
d3d8dd9
b8700fc
48a7f51
8042bc1
b9a7409
5584cff
b6a2da5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,6 +43,9 @@ async function appendRoutingSummary(existingCommands, selectedCommand) { | |
| } | ||
|
|
||
| function eventIdentifier() { | ||
| if (context.eventName === "pull_request_target") { | ||
| return "pull_request"; | ||
|
Comment on lines
+46
to
+47
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in b6a2da5: both dispatch paths now override |
||
| } | ||
| if (context.eventName !== "issue_comment") { | ||
| return context.eventName; | ||
| } | ||
|
|
@@ -53,6 +56,7 @@ function resolveBodyText() { | |
| const bodyByEvent = { | ||
| issues: context.payload?.issue?.body ?? "", | ||
| pull_request: context.payload?.pull_request?.body ?? "", | ||
| pull_request_target: context.payload?.pull_request?.body ?? "", | ||
| issue_comment: context.payload?.comment?.body ?? "", | ||
| pull_request_review_comment: context.payload?.comment?.body ?? "", | ||
| pull_request_review: context.payload?.review?.body ?? "", | ||
|
|
@@ -215,7 +219,8 @@ async function addImmediateReaction(reaction) { | |
| }); | ||
| return; | ||
| } | ||
| case "pull_request": { | ||
| case "pull_request": | ||
| case "pull_request_target": { | ||
| const prNumber = context.payload?.pull_request?.number; | ||
| if (!prNumber) { | ||
| core.warning("Skipping immediate reaction: pull request number was not found in payload."); | ||
|
|
@@ -730,6 +735,7 @@ async function main() { | |
| const routeReaction = normalizeReaction(route?.ai_reaction); | ||
| const awContext = { | ||
| ...buildAwContext(), | ||
| event_type: identifier, | ||
| command_name: "", | ||
| ...(routeReaction ? { desired_ai_reaction: routeReaction } : {}), | ||
| }; | ||
|
|
@@ -797,6 +803,7 @@ async function main() { | |
| const routeReaction = normalizeReaction(route?.ai_reaction); | ||
| const awContext = { | ||
| ...buildAwContext(), | ||
| event_type: identifier, | ||
| command_name: commandName, | ||
| ...(routeReaction ? { desired_ai_reaction: routeReaction } : {}), | ||
| ...(maintainsStatusComment(route) && statusCommentContext ? statusCommentContext : {}), | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in b6a2da5: added an explicit
git fetch origin "refs/pull/${PR_NUMBER}/head:refs/gh-aw/pr-${PR_NUMBER}/head"before the diff commands so the fork's head commit is present locally without checking it out.