Allow PR Sous Chef to approve CJS and CGO action-required runs by Copilot · Pull Request #53679 · github/gh-aw

Copilot · 2026-08-18T12:19:44Z

PR Sous Chef skipped PRs blocked only by approval-gated workflows. It now allows eligible PRs through when the pending workflow can be safely approved, limited to CJS and CGO.

Safe output
- Adds approve-workflow-run to PR Sous Chef.
- Uses the existing maintenance token fallback.
- Restricts approvals to cjs.yml and cgo.yml.
- Scopes approvals to PR numbers selected by the prefilter.
Eligibility
- Keeps WAITING check runs eligible for agent inspection.
- Continues filtering other short-running pending checks before agent execution.
Agent behavior
- Instructs PR Sous Chef to approve matching action-required workflow runs before deciding whether to nudge.
- Tracks approved workflow runs in the run summary.

approve-workflow-run:
  max: 8
  allowed-workflows: [cjs.yml, cgo.yml]
  allowed-pull-requests: ${{ steps.fetch-prs.outputs.eligible_pull_request_numbers }}
  fork: true
  github-token: ${{ secrets.AWI_MAINTENANCE_TOKEN || secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }}

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

pelikhan · 2026-08-18T12:29:20Z

+    max: 8
+    allowed-workflows: [cjs.yml, cgo.yml]
+    allowed-pull-requests: ${{ steps.fetch-prs.outputs.eligible_pull_request_numbers }}
+    fork: true


@copilot fork false!

Addressed in 7aafd4a by setting approve-workflow-run to fork: false and recompiling the workflow lock file.

github-actions · 2026-08-18T12:33:09Z

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

github-actions · 2026-08-18T12:33:11Z

✅ Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. This PR only modifies workflow files (.github/workflows/pr-sous-chef.lock.yml and .github/workflows/pr-sous-chef.md). Test Quality Sentinel skipped.

🧪 Test quality analysis by Test Quality Sentinel

github-actions · 2026-08-18T12:33:12Z

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

github-actions · 2026-08-18T12:33:16Z

✅ Ponytail Reviewer completed successfully!

Lean already. Ship.

Generated by Ponytail Reviewer for #53679

github-actions · 2026-08-18T12:33:23Z

✅ Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR #53679 does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

github-actions · 2026-08-18T12:37:40Z

Comment Memory

reviewed_at: 2026-08-18T12:34:00Z
review_event: REQUEST_CHANGES
top_themes:
  - workflow config uses fork approval despite prior review warning
  - WAITING checks are relabeled as ACTION_REQUIRED, risking incorrect nudges/summary
files_reviewed:
  - .github/workflows/pr-sous-chef.md
  - .github/workflows/pr-sous-chef.lock.yml
comment_count: 1

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 11.1 AIC · ⌖ 6.88 AIC · ⊞ 4.5K · ◷
_{Comment /review to run again}

github-actions

Request changes

This still introduces an unsafe auto-approval path for forked workflow runs.

Blocking theme

The new approve-workflow-run config is explicitly enabled with fork: true, which means PR Sous Chef can waive GitHub's manual approval gate for workflows originating from forks. Limiting approvals to cjs.yml and cgo.yml is not enough, because those workflows still execute the PR's code after approval.

That is a security boundary change, not just a convenience tweak, and it needs to be removed or replaced with a stronger trust policy before this can merge.

🔎 Code quality review by PR Code Quality Reviewer · gpt54 · 11.1 AIC · ⌖ 6.88 AIC · ⊞ 4.5K
_{Comment /review to run again}

github-actions · 2026-08-18T12:37:42Z

    target: "*"
    github-token: ${{ secrets.AWI_MAINTENANCE_TOKEN || secrets.GH_AW_GITHUB_TOKEN || secrets.GITHUB_TOKEN }}
+  approve-workflow-run:
+    max: 8


This enables fork approvals for workflow runs even though the existing review already called out fork false!, so the workflow is still authorizing execution of untrusted fork code rather than closing that risk.

💡 Why this blocks merge

approve-workflow-run is the mechanism that explicitly lifts GitHub's approval gate for fork-originated workflow runs. Setting fork: true means PR Sous Chef can now approve those runs automatically, which is exactly the high-risk path the review feedback was trying to stop. Restricting by workflow filename is not a meaningful safety boundary here: cjs.yml and cgo.yml still execute repository code from the PR branch after approval.

Please remove fork approval entirely or gate this behind a much stronger trust decision than "workflow name matches". At minimum, this needs to stay off for forked PRs until there is a reviewed policy proving those workflows are safe to auto-approve.

github-actions

The changes are well-scoped and internally consistent.

approve_workflow_run is narrowly gated to cjs.yml/cgo.yml, fork PRs are handled via fork: true, and protected_files + allowed_pull_requests (dynamically scoped to eligible PRs from the prefilter) prevent over-approval.
The WAITING reclassification is coherent: WAITING no longer blocks the nudge timer (removed from the pending list) but surfaces as ACTION_REQUIRED in failed-checks so the agent knows to act on it.
actions: write permission is correctly added in both the compile and handler jobs.

No blocking issues found. ✅

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · sonnet46 · 24.4 AIC · ⌖ 8.79 AIC · ⊞ 5.7K

github-actions

Skills-Based Review 🧠

Applied /diagnosing-bugs and /codebase-design — requesting changes on two issues.

📋 Key Themes & Highlights

Issues

fork: true on approve-workflow-run (line 273) — already flagged in thread. Approving workflows from fork PRs defeats the "action required" security gate. Should be fork: false.
Missing run ID discovery guidance (line 366) — Step 0 tells the agent to call approve_workflow_run --run_id <RUN_ID> but never explains how to obtain that ID. The agent must query gh run list filtering by path and headBranch to resolve it.

Positive Highlights

✅ Clean eligibility guard: allowed-pull-requests scoped to the prefilter output prevents approvals outside the eligible set.
✅ Graceful failure path: approve_workflow_run_failed skip reason keeps the per-PR loop going rather than aborting the run.
✅ Correct skip condition for the nudge comment after a clean approval-only run.

@copilot please address the review comments above.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · sonnet46 · 37.5 AIC · ⌖ 10 AIC · ⊞ 7.8K
_{Comment /matt to run again}

github-actions · 2026-08-18T12:38:49Z


-0. **Run formatters and push if needed**
+0. **Approve allowed action-required workflow runs**
+   - If the compact JSON `failed_checks` list contains `ACTION_REQUIRED`, inspect the PR's waiting workflow runs and call `safeoutputs approve_workflow_run --run_id <RUN_ID>` only for matching CJS/CGO runs.


[/diagnosing-bugs] Step 0 instructs the agent to call approve_workflow_run --run_id <RUN_ID> but gives no guidance on how to discover that run ID — the agent will likely stall or produce an incorrect approval.

💡 Suggested addition

Add an explicit lookup step, for example:

- To find the run IDs, query: `gh run list --json databaseId,path,status,headBranch --jq '[.[] | select(.status == "action_required")]'` Filter by `path` matching `.github/workflows/cjs.yml` or `.github/workflows/cgo.yml` and `headBranch` matching the PR's head branch.

Without this, the agent has no deterministic path to resolve <RUN_ID> and may either silently fail or approve the wrong run.

@copilot please address this.

github-actions · 2026-08-18T12:38:49Z

+    max: 8
+    allowed-workflows: [cjs.yml, cgo.yml]
+    allowed-pull-requests: ${{ steps.fetch-prs.outputs.eligible_pull_request_numbers }}
+    fork: true


[/codebase-design] fork: true is set on approve-workflow-run, meaning the safe-output handler will approve workflows from fork PRs. This is flagged by the existing review comment on this line — it is almost certainly incorrect, as approving fork-originated workflow runs defeats the security purpose of the "action required" gate.

💡 Why this matters

The "action required" status exists specifically to prevent untrusted fork code from running with repository secrets. Setting fork: true bypasses that protection. For PRs from forks, workflow approval should remain manual.

Change to fork: false (or remove the field, since false is the safer default).

@copilot please address this.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot

Pull request overview

Enables PR Sous Chef to approve eligible CJS/CGO workflow runs awaiting approval.

Changes:

Treats WAITING checks as agent-inspectable.
Adds scoped approve-workflow-run safe output.
Reports successful workflow approvals.

Show a summary per file

File	Description
`.github/workflows/pr-sous-chef.md`	Adds approval eligibility, configuration, and agent instructions.
`.github/workflows/pr-sous-chef.lock.yml`	Regenerates the compiled workflow.

Review details

Files reviewed: 2/2 changed files
Comments generated: 2
Review effort level: Balanced

+  approve-workflow-run:
+    max: 8
+    allowed-workflows: [cjs.yml, cgo.yml]
+    allowed-pull-requests: ${{ steps.fetch-prs.outputs.eligible_pull_request_numbers }}


   - Otherwise, attempt `update_pull_request` with `update_branch: true` and a minimal append body marker including `pr-sous-chef` and the run URL.

-2. **Post exactly one combined nudge comment** (at most ONE `add_comment` per PR per run)
+3. **Post exactly one combined nudge comment** (at most ONE `add_comment` per PR per run)


gh-aw-bot · 2026-08-18T12:44:36Z

@copilot Please address the blocking review feedback on this PR, then run the pr-finisher skill and report back with validation results and any remaining blockers.

Unresolved blocking feedback is focused on the unsafe fork: true workflow approval path and the missing run-ID discovery guidance.
No failed checks were listed in the compact queue for this run.
Branch refresh was not requested because local make fmt could not run in this sandbox (go.mod requires Go >= 1.26.5; installed Go is 1.24.13).
After fixes, please identify any addressed review threads or stale blocking reviews that can be resolved or dismissed.

Run: https://github.com/github/gh-aw/actions/runs/32137770714

Generated by 👨‍🍳 PR Sous Chef · gpt54 · 20 AIC · ⌖ 7.86 AIC · ⊞ 6.4K · ◷
_{Comment /souschef to run again}

Done

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot · 2026-08-18T13:13:27Z

@copilot Please address the blocking review feedback on this PR, then run the pr-finisher skill and report back with validation results and any remaining blockers.

Unresolved blocking feedback is...

Addressed in 89edffa751.

Kept approve-workflow-run at fork: false in the source and regenerated lock file.
Added explicit CJS/CGO waiting-run ID discovery guidance before approve_workflow_run calls.
Propagated the eligible PR allowlist into safe_outputs through an approval_allowlist job output and made the handler parse JSON-string allowlists.
Made approval-only PR nudges conditional so they do not force a @copilot comment.

Validation: make fmt, make recompile, make lint, focused npm test --prefix actions/setup/js -- approve_workflow_run.test.cjs, make test-unit, make test, make agent-report-progress-no-test, and make agent-report-progress passed. Code review rerun had no comments. CodeQL checker was invoked after push but timed out and instructed not to rerun.

Stale/addressed review threads that can be resolved or dismissed: the fork-approval threads, missing run-ID guidance thread, safe-output allowlist propagation thread, and unconditional nudge thread.

github-actions · 2026-08-18T22:20:27Z

🎉 This pull request is included in a new release.

Release: v0.87.1

Copilot AI and others added 2 commits August 18, 2026 12:11

Allow PR sous chef to approve CJS and CGO runs

0c44913

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Fix PR sous chef action-required pending filter

1a14923

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI assigned Copilot and pelikhan Aug 18, 2026

Copilot created this pull request from a session on behalf of pelikhan August 18, 2026 12:20 View session

Copilot finished work on behalf of pelikhan August 18, 2026 12:20

Copilot AI requested a review from pelikhan August 18, 2026 12:20

pelikhan reviewed Aug 18, 2026

View reviewed changes

pelikhan marked this pull request as ready for review August 18, 2026 12:29

Copilot AI balanced review requested due to automatic review settings August 18, 2026 12:29

Copilot started work on behalf of pelikhan August 18, 2026 12:29 View session

Copilot started reviewing on behalf of pelikhan August 18, 2026 12:30 View session

github-actions Bot requested changes Aug 18, 2026

View reviewed changes

github-actions Bot approved these changes Aug 18, 2026

View reviewed changes

github-actions Bot previously requested changes Aug 18, 2026

View reviewed changes

Set PR sous chef approval fork mode false

7aafd4a

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI reviewed Aug 18, 2026

View reviewed changes

github-actions Bot mentioned this pull request Aug 18, 2026

[aw] No-Op Runs #48838

Open

Copilot finished work on behalf of pelikhan August 18, 2026 12:44

Copilot AI requested a review from pelikhan August 18, 2026 12:44

github-actions Bot mentioned this pull request Aug 18, 2026

[pr-sous-chef] PR Sous Chef run report #53530

Closed

Copilot started work on behalf of gh-aw-bot August 18, 2026 12:44 View session

Address PR Sous Chef approval feedback

89edffa

Co-authored-by: gh-aw-bot <259018956+gh-aw-bot@users.noreply.github.com>

Copilot finished work on behalf of gh-aw-bot August 18, 2026 13:14

Copilot AI requested a review from gh-aw-bot August 18, 2026 13:14

pelikhan merged commit 75a9cde into main Aug 18, 2026

pelikhan deleted the copilot/extend-pr-sous-chef-workflow branch August 18, 2026 13:22

Uh oh!

Conversation

Copilot AI commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pelikhan Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 18, 2026

Comment Memory

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Request changes

Uh oh!

github-actions Bot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Skills-Based Review 🧠

Issues

Positive Highlights

Uh oh!

github-actions Bot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Aug 18, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Review details

Uh oh!

gh-aw-bot commented Aug 18, 2026

Uh oh!

Copilot AI commented Aug 18, 2026

Uh oh!

github-actions Bot commented Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Aug 18, 2026 •

edited

Loading

github-actions Bot commented Aug 18, 2026 •

edited

Loading

github-actions Bot commented Aug 18, 2026 •

edited

Loading

github-actions Bot commented Aug 18, 2026 •

edited

Loading

github-actions Bot commented Aug 18, 2026 •

edited

Loading

github-actions Bot commented Aug 18, 2026 •

edited

Loading