Add regression test diffing permissions.go constants against permissions schema enum - #54928
Merged
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add regression check for permissions constants against schema enum
Add regression test diffing permissions.go constants against permissions schema enum
Aug 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression test intended to prevent permission scope drift between Go definitions and JSON schema properties.
Changes:
- Parses both permission schema definitions.
- Adds bidirectional consistency checks.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/permissions_schema_consistency_test.go |
Adds permission/schema consistency tests. |
Review details
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
| // GITHUB_TOKEN-supported scopes (plus the special-cased copilot-requests scope, | ||
| // which is intentionally excluded from GetAllPermissionScopes() but must still be | ||
| // recognized) must appear under github_actions_permissions. | ||
| tokenScopes := append([]PermissionScope{}, GetAllPermissionScopes()...) |
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/workflow/permissions.go'sPermissionScopeconstants andpkg/parser/schemas/main_workflow_schema.json's$defs.github_actions_permissions/$defs.github_app_permissionsenums have drifted apart before (e.g. the missingsecret-scanning-alertsentry). Nothing previously caught this class of drift automatically.Changes
pkg/workflow/permissions_schema_consistency_test.gowith two tests that parse the schema JSON directly and cross-check it against the Go constants:TestPermissionConstantsMatchSchemaEnum— every scope fromGetAllPermissionScopes(),PermissionCopilotRequests, andGetAllGitHubAppOnlyScopes()must have a matching property in$defs.github_actions_permissionsor$defs.github_app_permissions.TestPermissionsSchemaEnumMatchesConstants— the inverse check, so the schema can't declare a scope with no corresponding Go constant either.Verified the test fails with a clear message when a scope (e.g.
secret-scanning-alerts) is removed from the schema, confirming it reproduces and guards against the original drift.