Skip to content

Collapse manual PR recovery instructions into a details section - #55667

Merged
pelikhan merged 1 commit into
mainfrom
copilot/improve-progressive-disclosure
Aug 25, 2026
Merged

Collapse manual PR recovery instructions into a details section#55667
pelikhan merged 1 commit into
mainfrom
copilot/improve-progressive-disclosure

Conversation

Copilot AI commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

When a push or PR creation fails and gh-aw falls back to an issue (e.g. #55651), the issue body dumps a ~25-line shell recovery script inline, burying the actual agent output. The manifest-protection fallback templates already hide equivalent instructions behind <details>; this applies the same treatment to the push-failure paths.

Changes

  • actions/setup/js/create_pull_request.cjs — in both push-failure fallback bodies (bundle transport and format-patch transport), the To create a pull request with the changes: heading + fenced sh block is now wrapped in a collapsible section titled Create the pull request manually, matching manifest_protection_push_failed_fallback.md.
  • The single-line gh pr create snippet in the PR-creation-failure fallback is intentionally left expanded — it is one command and does not benefit from disclosure.
> The bundle file is available in the `agent` artifact in the workflow run linked above.

<details>
<summary>Create the pull request manually</summary>

```sh
gh run download '32811847081' -n agent -D '/tmp/agent-32811847081'
...
```

No behavioral change beyond issue body markdown; existing create_pull_request tests and workflow recompilation are unaffected.

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI requested a review from pelikhan August 25, 2026 05:33
@pelikhan
pelikhan marked this pull request as ready for review August 25, 2026 05:37
Copilot AI balanced review requested due to automatic review settings August 25, 2026 05:37
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Design Decision Gate 🏗️ completed the design decision gate check.

No ADR enforcement needed: PR does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100).

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Test Quality Sentinel completed test quality analysis.

No test files were added or modified in this PR. Test Quality Sentinel skipped.

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Ponytail Reviewer completed successfully!

Lean already. Ship.

Generated by Ponytail Reviewer for #55667

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

Copy link
Copy Markdown
Contributor

Comment Memory

reviewed_at: 2026-08-25T00:00:00Z
review_event: COMMENT
top_themes:
  - no actionable issues in changed lines
  - markdown-only fallback body update
files_reviewed:
  - actions/setup/js/create_pull_request.cjs
comment_count: 0

Note

This comment is managed by comment memory.

It stores persistent context for this thread in the code block at the top of this comment.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔎 Code quality review by PR Code Quality Reviewer · pi · gpt54 · 3.7 AIC · ⌖ 6.85 AIC · ⊞ 7K ·
Comment /review to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: no blocking issues

This change only wraps the existing manual recovery shell block in a <details> section, and I don't see a correctness, security, or maintainability regression in the touched lines.

Scope reviewed
  • actions/setup/js/create_pull_request.cjs
  • Both push-failure fallback issue bodies (bundle and patch variants)
  • Existing surrounding markdown/template structure for closing fences and interpolation

🔎 Code quality review by PR Code Quality Reviewer · pi · gpt54 · 3.7 AIC · ⌖ 6.85 AIC · ⊞ 7K
Comment /review to run again

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /codebase-design — this is a pure markdown-template consistency fix.

The change is correct and complete: both push-failure fallback paths (bundle transport and format-patch transport) now match the <details> pattern already established in manifest_protection_push_failed_fallback.md. The deliberate exclusion of the single-line gh pr create snippet is well-reasoned and documented in the PR description.

✅ No logic changes, no behavioral regressions, consistent with the existing pattern.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet46 · 15.7 AIC · ⌖ 10.7 AIC · ⊞ 7.6K
Comment /matt to run again

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Wraps manual pull-request recovery scripts in collapsible sections for clearer fallback issues.

Changes:

  • Collapses bundle and patch recovery instructions.
  • Leaves concise PR-creation recovery expanded.
Show a summary per file
File Description
actions/setup/js/create_pull_request.cjs Adds disclosure blocks around manual recovery scripts.

Review details

Suppressed comments (1)

actions/setup/js/create_pull_request.cjs:2288

  • The patch-transport push-failure test checks the recovery commands but not that they are enclosed by this disclosure block. Please add assertions for the opening details/summary and matching closing tag so this path's new user-visible behavior is covered too.
<details>
<summary>Create the pull request manually</summary>
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment on lines +1918 to +1919
<details>
<summary>Create the pull request manually</summary>

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean UX improvement — collapsing the manual recovery instructions into a <details> block reduces visual noise in fallback issue/PR bodies while keeping all recovery steps accessible. The HTML is valid GitHub Markdown in both code paths. No issues found.

🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · copilot · sonnet46 · 13.5 AIC · ⌖ 9.02 AIC · ⊞ 6.2K

@pelikhan
pelikhan merged commit 34534c7 into main Aug 25, 2026
68 of 76 checks passed
@pelikhan
pelikhan deleted the copilot/improve-progressive-disclosure branch August 25, 2026 05:47
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.87.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants