Collapse manual PR recovery instructions into a details section - #55667
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. No ADR enforcement needed: PR does not have the 'implementation' label and has 0 new lines of code in business logic directories (threshold: 100).
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Test Quality Sentinel completed test quality analysis. No test files were added or modified in this PR. Test Quality Sentinel skipped.
|
|
✅ Ponytail Reviewer completed successfully! Lean already. Ship.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
Comment MemoryNote This comment is managed by comment memory.It stores persistent context for this thread in the code block at the top of this comment.
|
There was a problem hiding this comment.
Verdict: no blocking issues
This change only wraps the existing manual recovery shell block in a <details> section, and I don't see a correctness, security, or maintainability regression in the touched lines.
Scope reviewed
actions/setup/js/create_pull_request.cjs- Both push-failure fallback issue bodies (bundle and patch variants)
- Existing surrounding markdown/template structure for closing fences and interpolation
🔎 Code quality review by PR Code Quality Reviewer · pi · gpt54 · 3.7 AIC · ⌖ 6.85 AIC · ⊞ 7K
Comment /review to run again
There was a problem hiding this comment.
Skills-Based Review 🧠
Applied /codebase-design — this is a pure markdown-template consistency fix.
The change is correct and complete: both push-failure fallback paths (bundle transport and format-patch transport) now match the <details> pattern already established in manifest_protection_push_failed_fallback.md. The deliberate exclusion of the single-line gh pr create snippet is well-reasoned and documented in the PR description.
✅ No logic changes, no behavioral regressions, consistent with the existing pattern.
🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet46 · 15.7 AIC · ⌖ 10.7 AIC · ⊞ 7.6K
Comment /matt to run again
There was a problem hiding this comment.
Pull request overview
Wraps manual pull-request recovery scripts in collapsible sections for clearer fallback issues.
Changes:
- Collapses bundle and patch recovery instructions.
- Leaves concise PR-creation recovery expanded.
Show a summary per file
| File | Description |
|---|---|
actions/setup/js/create_pull_request.cjs |
Adds disclosure blocks around manual recovery scripts. |
Review details
Suppressed comments (1)
actions/setup/js/create_pull_request.cjs:2288
- The patch-transport push-failure test checks the recovery commands but not that they are enclosed by this disclosure block. Please add assertions for the opening details/summary and matching closing tag so this path's new user-visible behavior is covered too.
<details>
<summary>Create the pull request manually</summary>
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
| <details> | ||
| <summary>Create the pull request manually</summary> |
There was a problem hiding this comment.
Clean UX improvement — collapsing the manual recovery instructions into a <details> block reduces visual noise in fallback issue/PR bodies while keeping all recovery steps accessible. The HTML is valid GitHub Markdown in both code paths. No issues found.
🧵 Reviewed using Impeccable skills by Impeccable Skills Reviewer · copilot · sonnet46 · 13.5 AIC · ⌖ 9.02 AIC · ⊞ 6.2K
|
🎉 This pull request is included in a new release. Release: |
When a push or PR creation fails and gh-aw falls back to an issue (e.g. #55651), the issue body dumps a ~25-line shell recovery script inline, burying the actual agent output. The manifest-protection fallback templates already hide equivalent instructions behind
<details>; this applies the same treatment to the push-failure paths.Changes
actions/setup/js/create_pull_request.cjs— in both push-failure fallback bodies (bundle transport and format-patch transport), theTo create a pull request with the changes:heading + fencedshblock is now wrapped in a collapsible section titledCreate the pull request manually, matchingmanifest_protection_push_failed_fallback.md.gh pr createsnippet in the PR-creation-failure fallback is intentionally left expanded — it is one command and does not benefit from disclosure.No behavioral change beyond issue body markdown; existing
create_pull_requesttests and workflow recompilation are unaffected.