Fix MCP gateway auth validation and add version logging#9548
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…sive tests Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
💫 TO BE CONTINUED... Smoke Claude failed! Our hero faces unexpected challenges... |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
@copilot update the check MCP gateway to fail if the gateway configuration is missing authorization headers. See https://github.com/githubnext/gh-aw/actions/runs/20884658107/job/60006066256#step:24:1 Log the gateway version in the action logs for easy review. |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Done in commit 8174f0f. Changes:
Both changes tested and verified. All 17 existing tests still pass. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
🎉 Yo ho ho! Changeset Generator found the treasure and completed successfully! ⚓💰 |
|
💫 TO BE CONTINUED... Smoke Claude failed! Our hero faces unexpected challenges... |
|
✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟 |
|
📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤 |
|
@copilot Review how the check_mcp_gateway is invoked . The error is not progapated as one can see in https://github.com/githubnext/gh-aw/actions/runs/20884936058/job/60006717966#step:24:1 It is probably the piping to a log file. |
Plan: Add Gateway Version Logging and Fail on Missing Auth Headers
Requirements from Comment
The comment requests two changes:
Analysis
Current Behavior (check_mcp_servers.sh lines 133-141):
Changes Completed
set -o pipefailto start_mcp_gateway.shImplementation Details
Authorization header check (check_mcp_servers.sh lines 138-143):
Gateway version logging (start_mcp_gateway.sh lines 238-241):
.gateway.versionfieldError propagation fix (start_mcp_gateway.sh line 10):
set -o pipefailto ensure pipeline failures are detectedtee, only tee's exit code was checkedOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.