Skip to content

Fix MCP gateway step succeeding when server checks fail #9555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 2 commits into from
Jan 10, 2026
Merged

Fix MCP gateway step succeeding when server checks fail #9555

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e848f1
Initial plan
Copilot Jan 10, 2026
390d145
Enable pipefail for check_mcp_servers.sh to catch failures
Copilot Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions actions/setup/sh/start_mcp_gateway.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,8 @@ if [ -f /opt/gh-aw/actions/check_mcp_servers.sh ]; then
echo "Running MCP server checks..."
# Store check diagnostic logs in /tmp/gh-aw/mcp-logs/start-gateway.log for artifact upload
# Use tee to output to both stdout and the log file
# Enable pipefail so the exit code comes from check_mcp_servers.sh, not tee
set -o pipefail
if ! bash /opt/gh-aw/actions/check_mcp_servers.sh \
/tmp/gh-aw/mcp-config/gateway-output.json \
"http://localhost:${MCP_GATEWAY_PORT}" \
Expand All @@ -301,6 +303,7 @@ if [ -f /opt/gh-aw/actions/check_mcp_servers.sh ]; then
kill $GATEWAY_PID 2>/dev/null || true
exit 1
fi
set +o pipefail
else
echo "WARNING: MCP server check script not found at /opt/gh-aw/actions/check_mcp_servers.sh"
echo "Skipping MCP server functionality checks"
Expand Down
Loading