Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for New Ghost Feature Integration issue: #1514 #1515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BarShauli555
Copy link

@BarShauli555 BarShauli555 commented Mar 18, 2025

A Pull Request should be associated with an Issue.

Related issue: #1514

Further notes in https://github.com/github/gh-ost/blob/master/.github/CONTRIBUTING.md
Thank you! We are open to PRs, but please understand if for technical reasons we are unable to accept each and any PR

Description

This PR :

I have added a new PR for this feature, and the code is currently running in our production environment and testing.

The PR includes:
A new WHERE clause statement, defaulting to 1=1. Here’s an example of filter operations:

Comparison operators: “<, >, =, !=”

  1. data_created > year('2020')
  2. id >= 100
  3. status IN ('done') # Please use a maximum of 5 values for IN; otherwise, use a temp table.

Sub-select from a temp table:

  1. id IN (SELECT id FROM temp_id) - Preferred for primary keys; otherwise, it’s a heavy process.
  2. varchar_column IN (SELECT varchar_column FROM varchar_temp_table)

Adding the receiving condition to the SQL builder mechanism that filters in the data according to our additional statement in the WHERE clause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant