Skip to content

Fix import path for win32 platform - #151

Merged
ncalteen merged 1 commit into
mainfrom
ncalteen/win32
Feb 6, 2025
Merged

Fix import path for win32 platform#151
ncalteen merged 1 commit into
mainfrom
ncalteen/win32

Conversation

@ncalteen

@ncalteen ncalteen commented Feb 6, 2025

Copy link
Copy Markdown
Collaborator

This PR fixes an incorrect import path for win32-based systems to ensure the correct, absolute path is provided to the action import logic.

Closes #123

@ncalteen ncalteen self-assigned this Feb 6, 2025
Copilot AI review requested due to automatic review settings February 6, 2025 19:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again, by re-requesting a review.

@ncalteen
ncalteen requested a review from Copilot February 6, 2025 19:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR addresses an incorrect import path on Windows by constructing an OS-specific entrypoint path, ensuring that the action can be properly imported or required.

  • Introduces a new osEntrypoint variable that prepends a slash on Windows and replaces path separators.
  • Updates ESM and CJS loading logic to use the new osEntrypoint on Windows.

Changes

File Description
src/commands/run.ts Introduces an OS-specific entrypoint variable and updates the import/require calls for ESM and CJS usage.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

Comment thread src/commands/run.ts
@github-actions

github-actions Bot commented Feb 6, 2025

Copy link
Copy Markdown

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.09s
✅ JAVASCRIPT prettier 11 0 1.02s
✅ JSON jsonlint 24 0 0.49s
✅ JSON npm-package-json-lint yes no 1.52s
✅ JSON prettier 24 0 2.07s
✅ MARKDOWN markdownlint 8 0 3.33s
✅ REPOSITORY checkov yes no 27.93s
✅ REPOSITORY gitleaks yes no 3.95s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 23.88s
✅ REPOSITORY secretlint yes no 0.96s
✅ REPOSITORY trivy yes no 12.17s
✅ REPOSITORY trivy-sbom yes no 1.1s
✅ REPOSITORY trufflehog yes no 30.11s
✅ TYPESCRIPT prettier 68 0 3.79s
✅ YAML prettier 21 0 0.86s
✅ YAML yamllint 21 0 0.59s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@ncalteen
ncalteen merged commit 9d60787 into main Feb 6, 2025
@ncalteen
ncalteen deleted the ncalteen/win32 branch February 6, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ERR_UNSUPPORTED_ESM_URL_SCHEME]: Only URLs with a scheme in: file, data, and node are supported by the default ESM loader.

2 participants