This repository was archived by the owner on May 5, 2020. It is now read-only.
Use byteslice instead of slice in fragment_for - #52
Merged
Conversation
haileys
pushed a commit
that referenced
this pull request
Mar 31, 2014
Use byteslice instead of slice in fragment_for
|
Because encodings? |
|
There was a test as well. It didn't apply? |
Author
|
@mislav Ugh, yeah I missed that. |
Author
|
@rsanheim Yep, see the github/github issue referenced above. |
This was referenced Apr 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @github/rails @github/rails3