Adjust importer's push limits #100
Merged
+26
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR adjusts the GEI push limits by setting a default push size of 40 GiB for imports and allowing an increased limit of 80 GiB when both import and allow-list flags are enabled.
- Use a switch statement to differentiate between import cases.
- Update comments to clarify the two cases for push limits.
Reviewed Changes
| File | Description |
|---|---|
| internal/spokes/spokes.go | Updated logic in getMaxInputSize() to handle different push limits for GEI imports |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
migue
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterating on #84, we'd like the default limit for pushes by GEI to be 40 GiB, with an option to raise the limit to 80 GiB.
cc @iomekam @ttaylorr @mhagger @elhmn
cc https://github.slack.com/archives/C12RL65A9/p1741290565885329 (no xref because this is a public repo!)