Skip to content

Prune dependencies and the features twirp-rs depends on, cargo update, fix ci #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2024
Merged

Prune dependencies and the features twirp-rs depends on, cargo update, fix ci #18

merged 2 commits into from
Mar 20, 2024

Conversation

tclem
Copy link
Member

@tclem tclem commented Mar 20, 2024 •
edited
Loading

I've better marked which crates are required by client vs. server features and reduces the features we depend on in each of those dependencies.

I updated CI to run on pull requests and properly call the make targets which fully exercise all the code.

I also ran cargo update for good measure. This should address https://github.com/github/twirp-rs/security/dependabot/2

@tclem tclem requested a review from a team as a code owner March 20, 2024 18:03
jorendorff
jorendorff approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@jorendorff jorendorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tclem tclem merged commit ec98b3a into main Mar 20, 2024
1 check passed
@tclem tclem deleted the tclem/prune-features branch March 20, 2024 18:17
@tclem tclem mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorendorff jorendorff jorendorff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tclem @jorendorff