Skip to content

fix(compile): trust generated SafeOutputs MCP for Copilot#1462

Merged
jamesadevine merged 7 commits into
mainfrom
copilot/agent-issue-make-safeoutputs-trusted
Jul 11, 2026
Merged

fix(compile): trust generated SafeOutputs MCP for Copilot#1462
jamesadevine merged 7 commits into
mainfrom
copilot/agent-issue-make-safeoutputs-trusted

Conversation

Copilot AI commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Copilot CLI requires compiler-generated MCP servers to be explicitly trusted and allowed, even when the workflow uses wildcard tool access. Without that, generated SafeOutputs MCP access depends on non-source lock-file edits.

  • Copilot MCP config

    • Marks generated MCPG server entries as default/trusted:
      .value.tools = ["*"] | .value.isDefaultServer = true
  • Copilot permissions

    • Preserves compiler-owned extension grants on the --allow-all-tools path.
    • Generated invocations now include:
      --allow-all-tools --allow-tool safeoutputs
  • Coverage

    • Pins wildcard/default Copilot args to include --allow-tool safeoutputs.
    • Pins MCPG-to-Copilot conversion to emit isDefaultServer: true.

Test plan

  • cargo build
  • cargo test
  • cargo clippy --all-targets --all-features
  • Manual compile of a SafeOutputs workflow and inspection of generated lock YAML

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix generated SafeOutputs MCP to be trusted by Copilot CLI fix(compile): trust generated SafeOutputs MCP for Copilot Jul 10, 2026
Copilot AI requested a review from jamesadevine July 10, 2026 13:40
@jamesadevine

Copy link
Copy Markdown
Collaborator

@copilot Merge main and ensure the new copilot/ safeoutputs contract test succeeds.

Copilot AI and others added 4 commits July 11, 2026 12:36
…ake-safeoutputs-trusted

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>
Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Merge main and ensure the new copilot/ safeoutputs contract test succeeds.

Merged origin/main in bfdb795 and enabled/validated the Copilot SafeOutputs contract checks in 4ef7b9a (latest cleanup a46d0a0). cargo test --test copilot_cli_safeoutputs_tests passes locally.

@jamesadevine jamesadevine marked this pull request as ready for review July 11, 2026 14:00
@jamesadevine

Copy link
Copy Markdown
Collaborator

@copilot Restore ignore in the tests.

Co-authored-by: jamesadevine <4742697+jamesadevine@users.noreply.github.com>

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Restore ignore in the tests.

Restored the ignored markers for the Copilot SafeOutputs tests in 8417509. cargo test --test copilot_cli_safeoutputs_tests now reports all three tests ignored by default.

@jamesadevine jamesadevine merged commit 2e85e40 into main Jul 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants