test(compile): fix named-pool 1ES test on Windows CRLF checkout

[jamesadevine]

Summary

The Daily Build failed only on Windows on 12 & 13 July via the test test_named_pool_demands_compile_to_1es_shared_pool (tests/compiler_tests.rs), panicking with 1ES output should contain extends.parameters.pool mapping.

Root cause (test bug introduced by #1461 feat(compile): support named pool demands):

• On Windows, git checks out the named-pool-demands-agent.md fixture with CRLF line endings (core.autocrlf=true, no .gitattributes override for fixtures).
• The test helper compile_named_pool_demands_fixture_for_target injected target: 1es via replacen("description: \"...\"\n", ...) using a bare \n.
• Against CRLF content the pattern never matched, so target: 1es was silently dropped. The fixture then compiled as the default standalone target — which has no extends.parameters.pool — tripping the assertion.
• The sibling job/stage cases passed vacuously (standalone still exposes an Agent job with a pool), so only the 1ES case surfaced the bug.

Fix: normalize \r\n → \n in the transform closure before the replacen, so the target override applies regardless of checkout line endings. This is purely a test-harness issue; the compiler itself was never broken.

Test plan

• cargo test --test compiler_tests named_pool → 3 passed (previously failed on Windows)
• cargo test --test compiler_tests → 184 passed, 0 failed (on Windows)

[github-actions]

🔍 Rust PR Review

Summary: Looks good — correct, minimal fix for the Windows CRLF test failure.

Findings

✅ What Looks Good

• The root cause diagnosis is accurate: replacen with a bare \n pattern fails against CRLF content, silently dropping the target: 1es override.
• The fix is correctly scoped to the test harness closure, not the compiler itself.
• Normalizing \r\n → \n before the replacen is the right approach — it's idempotent on LF-only systems and correctly handles CRLF on Windows.
• The comment clearly explains why the normalization is needed and when it triggers, which is useful for future readers.
• No concerns around correctness, security, or project conventions — this is a pure test hygiene fix.

Generated by Rust PR Reviewer for #1487 · 18.8 AIC · ⌖ 5.58 AIC · ⊞ 6.2K · ◷