Skip to content

test: correct mislabelled vacuous test in src/compile/types.rs #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamesadevine merged 1 commit into from
Jul 15, 2026
Merged

test: correct mislabelled vacuous test in src/compile/types.rs #1518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/compile/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4360,8 +4360,9 @@ Body
}

#[test]
fn test_front_matter_safe_outputs_triggers_conclusion_job() {
// Any non-empty safe-outputs triggers the conclusion job
fn test_front_matter_safe_outputs_noop_object_form() {
// `noop: {}` must parse as an empty mapping — distinct from
// `noop: false` (disable) and bare `noop:` (null/default).
let content = r#"---
name: "Test Agent"
description: "Test"
Expand All @@ -4372,6 +4373,11 @@ safe-outputs:
Body
"#;
let (fm, _) = super::super::common::parse_markdown(content).unwrap();
assert!(!fm.safe_outputs.is_empty(), "safe_outputs should be non-empty");
let noop = fm.safe_outputs.get("noop").expect("noop key must be present");
assert!(
noop.is_object(),
"noop: {{}} must parse as an object, not bool or null; got: {:?}",
noop
);
}
}
Loading