test: fix vacuous assertion in mcp_http_tests#1557
Merged
jamesadevine merged 1 commit intoJul 21, 2026
Conversation
test_auth_accepts_correct_token used assert_ne!(status, 401) which passes even on 500 errors. Replace with assert!(status.is_success()) so the test actually verifies the server accepts the correct token. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jamesadevine
marked this pull request as ready for review
July 21, 2026 13:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Suite Reduction: tests/mcp_http_tests.rs
What was wrong
test_auth_accepts_correct_token: the assertionassert_ne!(resp.status(), 401, "Correct API key should not be rejected")is vacuous — it passes on any response that isn't a 401, including 400 Bad Request, 500 Internal Server Error, etc. The test name implies the server accepts the token (i.e. returns a success response), but the assertion only verifies it was not rejected with a 401. A bug that caused the server to crash on valid tokens would go undetected.Changes
test_auth_accepts_correct_tokenassert!(status.is_success())Verification
cargo test --test mcp_http_tests: all 8 tests pass ✅cargo check --tests: no errors ✅