docs(site): add codemod 0005 to file layout in codemods reference#1559
Draft
github-actions[bot] wants to merge 1 commit into
Draft
docs(site): add codemod 0005 to file layout in codemods reference#1559github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
The 'Adding a codemod' file layout tree still listed only 0001-0004 even though 0005_drop_build_attachment_allowed_build_ids.rs was added to the source tree (and already appeared in the Registered codemods table). The contributor contract says the layout tree should mirror the actual directory, so a new contributor counting files would see a mismatch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codemods.mdxlisted only files0001–0004, but0005_drop_build_attachment_allowed_build_ids.rswas added to the source tree in v0.42.0. A contributor following the reference to write a new codemod would count the existing files, see a mismatch with the "Registered codemods" table directly above, and lose confidence in the doc.Changes
site/src/content/docs/reference/codemods.mdx— added0005_drop_build_attachment_allowed_build_ids.rsto the file layout tree; also aligned comment column spacing so the tree is easier to scan.Accuracy checks
0005_drop_build_attachment_allowed_build_ids.rsexists insrc/compile/codemods/(lsoutput confirmed).drop_build_attachment_allowed_build_idsas of PR docs(site): remove stale allowed-build-ids from upload-build-attachment and add codemod 0005 #1497 — this just brings the file tree in the contributor section into sync.Validation
cd site && npm run build:astro— 38 pages built, all internal links valid.Created by the docs-writer workflow.
Warning
Firewall blocked 1 domain
The following domain was blocked by the firewall during workflow execution:
cdn.playwright.devSee Network Configuration for more information.